Skip to content

Fix PHP 8.5 curl_close() deprecation #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lohanidamodar wants to merge 1 commit into from
Closed

Fix PHP 8.5 curl_close() deprecation #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Analytics/Adapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,6 @@ public function call(string $method, string $path = '', array $headers = [], arr

return $responseBody;
} finally {
curl_close($ch);
}
}
Comment on lines 185 to 188
Copy link
Copy Markdown

@greptile-apps greptile-apps Bot May 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The finally block is now empty after removing curl_close(). An empty finally block has no effect and can be removed entirely to keep the code clean.

Suggested change
return $responseBody;
} finally {
curl_close($ch);
}
}
return $responseBody;
}
}


Expand Down
Loading