Fix PHP 8.5 curl_close() deprecation#62
Conversation
curl_close() has been a no-op since PHP 8.0 and is now formally deprecated in 8.5. The curl handle is freed when the variable goes out of scope. Refs: CLO-4290
Greptile SummaryRemoves the deprecated Confidence Score: 5/5Safe to merge; a one-line removal of a no-op call with a minor style nit about the leftover empty Single targeted change with no functional impact; no P0/P1 issues found. One P2 style suggestion to also remove the now-empty No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "Remove deprecated curl_close() call (PHP..." | Re-trigger Greptile |
| return $responseBody; | ||
| } finally { | ||
| curl_close($ch); | ||
| } | ||
| } |
|
Superseded by full migration to |
Summary
curl_close($ch)call inAnalytics\Adapterthat triggers aDeprecatednotice on PHP 8.5.Why
curl_close()has been a no-op since PHP 8.0 and is now formally deprecated in 8.5. The curl handle is freed when the variable goes out of scope.Test plan
composer lint(Pint) — passphp -l src/Analytics/Adapter.php— clean(Note: this repo does not define a
composer analyze/PHPStan script; lint is the configured gate.)