test(engine): add ffprobe-unavailable fallback regression tests#379
Open
vanceingalls wants to merge 1 commit intovance/shader-midpoint-testsfrom
Open
test(engine): add ffprobe-unavailable fallback regression tests#379vanceingalls wants to merge 1 commit intovance/shader-midpoint-testsfrom
vanceingalls wants to merge 1 commit intovance/shader-midpoint-testsfrom
Conversation
This was referenced Apr 21, 2026
Collaborator
Author
This was referenced Apr 21, 2026
Open
perf(producer): hdr benchmark harness — --tags filter, peak heap/RSS tracking, bench:hdr script
#382
Open
0294c06 to
cc0422f
Compare
2163cd0 to
ca9c359
Compare
cc0422f to
8638446
Compare
ca9c359 to
d8c43e8
Compare
dad30f7 to
b3cd341
Compare
1733e38 to
6881964
Compare
b3cd341 to
25fb68e
Compare
c1d8c12 to
1f9a361
Compare
de75bbd to
817ab68
Compare
1f9a361 to
f6c9af0
Compare
817ab68 to
1af0218
Compare
f6c9af0 to
addad95
Compare
1af0218 to
7923df2
Compare
addad95 to
500c56b
Compare
2b3dd2c to
4b1cbf9
Compare
500c56b to
652f647
Compare
4b1cbf9 to
f2464f3
Compare
9e0d048 to
1655176
Compare
f2464f3 to
72f4d29
Compare
1655176 to
16e2fa4
Compare
72f4d29 to
2196dec
Compare
16e2fa4 to
58f97e9
Compare
2196dec to
2c19da9
Compare
58f97e9 to
ea05258
Compare
2c19da9 to
40e2154
Compare
ea05258 to
b4fa284
Compare
40e2154 to
efe5bcb
Compare
b4fa284 to
193ed00
Compare
633de87 to
ef05bfc
Compare
ff0f25b to
e24208f
Compare
Mock node:child_process.spawn to surface ENOENT and verify that: - extractMediaMetadata falls back to PNG cICP metadata for image inputs - extractMediaMetadata rethrows for non-image inputs lacking a still-image fallback - extractAudioMetadata + analyzeKeyframeIntervals propagate the install-hint error verbatim Closed gap from hdr-followups Chunk 9B.
ef05bfc to
1b05a9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Mock
node:child_process.spawnto surfaceENOENTand verify ffprobe's three callers behave correctly when ffprobe is missing.Why
Chunk 9Bofplans/hdr-followups.md. The PNG cICP fallback inextractMediaMetadatawas added to support environments without ffprobe, but no test pinned the behavior — silently regressing it would break HDR image support on any system without ffprobe installed.What changed
packages/engine/src/utils/ffprobe.test.ts: mockschild_process.spawnto surfaceENOENTand asserts:extractMediaMetadatafalls back to PNG cICP metadata for image inputs.extractMediaMetadatarethrows for non-image inputs lacking a still-image fallback.extractAudioMetadata+analyzeKeyframeIntervalspropagate the install-hint error verbatim.Test plan
Stack
Chunk 9B of
plans/hdr-followups.md. Test-only change, independent of all other chunks.