test(hdr-regression): tighten Window C maxFrameFailures budget after Chunk 1 fix

[vanceingalls]

Summary

Tighten hdr-regression Window C maxFrameFailures from 30 → 5 now that Chunk 1 (opacity pipeline) has landed.

Why

Window C (direct <video> opacity tween) was previously listed as a known failure with a maxFrameFailures budget of 30 to absorb expected drift until Chunk 1 landed. After the Chunk 1 fix, the regression test passes against the existing golden with 0 failed frames. Tightening the budget catches any future drift in the opacity path immediately rather than letting up to 30 broken frames slip through.

What changed

• tests/hdr-regression/meta.json: maxFrameFailures 30 → 5 (small budget remains for HEVC encoder noise).
• tests/hdr-regression/README.md: updated to mark Window C as fixed and note the tightened budget.

The HEVC encoder is byte-deterministic and the opacity fix doesn't perturb pixels at the PSNR ≥ 28 checkpoint threshold, so regenerating the golden produces byte-identical output. The golden is therefore unchanged. Window F (transform + border-radius) remains pending Chunk 4; its broken state is currently baked into the golden, so the suite is green and Chunk 4's regen will catch any drift.

Test plan

• bun run test --filter hdr-regression — passes with 0 failed frames at the new budget.

Stack

Follow-up to Chunk 1 (opacity pipeline). Reviewable separately so the golden churn (none in this case) is decoupled from the code fix.

[vanceingalls]

• docs(engine): document __name polyfill and add regression test #385
• perf(producer): cache transfer-converted hdr image buffers per render job #384
• perf(producer): gate per-frame debug meta via optional isLevelEnabled #383
• perf(producer): hdr benchmark harness — --tags filter, peak heap/RSS tracking, bench:hdr script #382
• test(producer): extract frameDirMaxIndexCache to its own module and pin cross-job isolation #381
• test(engine): cover spawnStreamingEncoder lifecycle and cleanup paths #380
• test(engine): add ffprobe-unavailable fallback regression tests #379
• test(shader-transitions): add midpoint (p=0.5) regression invariants for all shaders #378
• test(engine): lock down sRGB→BT.2020 LUT with byte-exact reference values #377
• build(lfs): track tests/*/src/*.png via Git LFS #376
• test(hdr-regression): tighten Window F maxFrameFailures budget after Chunk 4 fix #375
• fix(engine,shader): handle matrix3d transforms and hide non-first scenes #374
• refactor(producer): extract HDR compositing helpers and rename media metadata #373
• fix(producer): wire --crf and --video-bitrate CLI overrides into encoders #372
• fix(producer): tighten resource lifecycle and harden file server #371
• feat(engine): wire options.hdr through chunkEncoder + dynamic SDR→HDR transfer #370
• test(hdr-regression): tighten Window C maxFrameFailures budget after Chunk 1 fix #369 👈 (View in Graphite)
• fix(engine): stop clobbering native <video> opacity in HDR pipeline #368
• refactor(shader-transitions): extract DEFAULT_DURATION and DEFAULT_EASE constants #367
• refactor(types): tighten type safety, dedupe HfTransitionMeta, prune dead LUT export #366
• test(producer): add hdr-regression and hdr-hlg-regression test suites #365
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[jrusso1020]

Budget tightening is the right mechanical proof that #368 worked: Window C was a documented known-fail with a generous maxFrameFailures budget; now that the direct-<video>-opacity fix has landed, the golden is regenerated against the corrected output and the budget drops to 5 to leave only codec-noise slack. Exactly the pattern the stack documented.

One nit I'd note for future budget changes: the README now reads "tightened from 30 → 5", which is useful history, but it'd be worth a one-line comment in meta.json too (or the commit message) for whoever's bisecting a future drift — grepping commit history for a budget tightening gives you the fix it was proving, which is valuable forensic info.

Approved.

— Rames Jusso

[vanceingalls]

Merge activity

• Apr 23, 3:14 AM UTC: @vanceingalls merged this pull request with Graphite.