cibuild.sh: enable -Werror for precheck and nightly build defaultly#34
Merged
xiaoxiang781216 merged 1 commit intoapache:masterfrom Apr 17, 2020
Merged
cibuild.sh: enable -Werror for precheck and nightly build defaultly#34xiaoxiang781216 merged 1 commit intoapache:masterfrom
xiaoxiang781216 merged 1 commit intoapache:masterfrom
Conversation
Signed-off-by: liuhaitao <liuhaitao@xiaomi.com>
Ouss4
approved these changes
Apr 16, 2020
Member
Ouss4
left a comment
Ouss4
left a comment
There was a problem hiding this comment.
LGTM.
However the checks will always fail as there is a config with a couple of warnings.
Contributor
|
All warning get fixed, let' enable the more strict check now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on apache/nuttx#792 merged in, and then all the existing warnings fixed. So defer to merge it now.