Fix bas_program.c build warning under macos#184
Merged
xiaoxiang781216 merged 2 commits intoapache:masterfrom Apr 17, 2020
Merged
Fix bas_program.c build warning under macos#184xiaoxiang781216 merged 2 commits intoapache:masterfrom
xiaoxiang781216 merged 2 commits intoapache:masterfrom
Conversation
bas_program.c:234:35: error: adding 'size_t' (aka 'unsigned long') to a string does not append to the string [-Werror,-Wstring-plus-int]
FS_putChars(chn, " " + len);
~~~~~~~~~~~^~~~~
bas_program.c:234:35: note: use array indexing to silence this warning
FS_putChars(chn, " " + len);
^
& [ ]
1 error generated.
Signed-off-by: liuhaitao <liuhaitao@xiaomi.com>
Note that mixed case identifier still keep in use. Signed-off-by: liuhaitao <liuhaitao@xiaomi.com>
Contributor
|
lgtm |
Contributor
|
Since the modification is minor but github action is unstable now, let's merge this PR to unblock the warning as error PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bas_program.c:234:35: error: adding 'size_t' (aka 'unsigned long') to a string does not append to the string [-Werror,-Wstring-plus-int]
FS_putChars(chn, " " + len);
~~~~~~~~~~~^~~~~
bas_program.c:234:35: note: use array indexing to silence this warning
FS_putChars(chn, " " + len);
^
& [ ]
1 error generated.
Signed-off-by: liuhaitao liuhaitao@xiaomi.com