Skip to content

refactor: update sketchlib import paths for top-k module renames #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zzylol merged 2 commits into from
May 4, 2026
Merged

refactor: update sketchlib import paths for top-k module renames #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d80df16
refactor: update sketchlib import paths for top-k module renames
GordonYuanyc May 4, 2026
41efe7f
chore: bump asap_sketchlib lockfile to pick up topk renames
GordonYuanyc May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion asap-query-engine/src/precompute_operators/count_min_sketch_accumulator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ use crate::data_model::{
AggregateCore, AggregationType, KeyByLabelValues, MergeableAccumulator,
MultipleSubpopulationAggregate, SerializableToSink,
};
use asap_sketchlib::sketches::countmin::CountMinSketch;
use asap_sketchlib::sketches::countminsketch::CountMinSketch;
use serde_json::Value;
use std::collections::HashMap;

Expand Down
6 changes: 3 additions & 3 deletions asap-query-engine/src/precompute_operators/count_min_sketch_with_heap_accumulator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,22 @@ use crate::data_model::{
AggregateCore, AggregationType, KeyByLabelValues, MergeableAccumulator,
MultipleSubpopulationAggregate, SerializableToSink,
};
use asap_sketchlib::sketches::cms_heap::{CmsHeapItem, CountMinSketchWithHeap};
use asap_sketchlib::sketches::countminsketch_topk::{CmsHeapItem, CountMinSketchWithHeap};
use serde_json::Value;
use std::collections::HashMap;

use promql_utilities::query_logics::enums::Statistic;

/// Count-Min Sketch with Heap accumulator — wraps `asap_sketchlib::sketches::CountMinSketchWithHeap`.
/// Core struct, update/merge/serde logic live in `asap_sketchlib::sketches::cms_heap`.
/// Core struct, update/merge/serde logic live in `asap_sketchlib::sketches::countminsketch_topk`.
/// This file retains QE-specific trait impls, legacy deserializers, and JSON output.
#[derive(Debug, Clone)]
pub struct CountMinSketchWithHeapAccumulator {
pub inner: CountMinSketchWithHeap,
}

// Re-export HeapItem so existing code using CountMinSketchWithHeapAccumulator::HeapItem still works.
pub use asap_sketchlib::sketches::cms_heap::CmsHeapItem as HeapItemReexport;
pub use asap_sketchlib::sketches::countminsketch_topk::CmsHeapItem as HeapItemReexport;

impl CountMinSketchWithHeapAccumulator {
pub fn new(row_num: usize, col_num: usize, heap_size: usize) -> Self {
Expand Down
Loading