refactor: update sketchlib import paths for top-k module renames#321
Merged
Conversation
Tracks the module renames in asap_sketchlib PR #39: - sketches::countmin -> sketches::countminsketch - sketches::cms_heap -> sketches::countminsketch_topk Type names (CountMinSketch, CountMinSketchWithHeap, CmsHeapItem) are unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
cargo update -p asap_sketchlib: d22a9ab -> 81c3436 Required so the import-path changes in this branch resolve against the post-rename sketchlib on main. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
zzylol
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asap-query-engine/src/precompute_operators/:sketches::countmin→sketches::countminsketchsketches::cms_heap→sketches::countminsketch_topkCountMinSketch,CountMinSketchWithHeap,CmsHeapItem) are unchanged — only module paths moved.Dependency / merge order
Cargo.tomlpullsasap_sketchlibfrom gitmain, so this PR will only build green after asap_sketchlib#39 lands onmain. Merge that first, then this.Test plan
cargo build/cargo checkagainst updated sketchlib🤖 Generated with Claude Code