Skip to content

Fix crash on selecting some Imbued gems + trigger supports not working #9793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 2 commits into from
Apr 20, 2026
+9 −4
Merged

Fix crash on selecting some Imbued gems + trigger supports not working #9793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
874d423
Fix invalid imbued gems appearing in list
Apr 20, 2026
ae2e2fd
Fix Cast on Crit and other secondary granted effects
Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Classes/GemSelectControl.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,8 @@ function GemSelectClass:PopulateGemList()
local levelRequirement = gemData.grantedEffect.levels[1].levelRequirement or 1
if characterLevel >= levelRequirement or not matchLevel then
if self.imbuedSelect then
-- Imbued dropdown only allows non-exceptional support gems.
if gemData.grantedEffect.support and not gemData.tagString:match("Exceptional") and not gemData.grantedEffect.plusVersionOf then
-- Imbued dropdown only allows non-exceptional support gems and supports that don't grant active skills
if gemData.grantedEffect.support and not gemData.tagString:match("Exceptional") and not gemData.grantedEffect.plusVersionOf and (not gemData.secondaryGrantedEffect or gemData.secondaryGrantedEffect.support) then
self.gems["Default:" .. gemId] = gemData
end
else
Expand All @@ -139,7 +139,7 @@ function GemSelectClass:FilterSupport(gemId, gemData)
end

if self.imbuedSelect then
return gemData.grantedEffect.support and not gemData.tagString:match("Exceptional") and self.sortCache.canSupport[gemId]
return self.sortCache.canSupport[gemId]
end

return (not gemData.grantedEffect.support
Expand Down
7 changes: 6 additions & 1 deletion src/Modules/CalcSetup.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1516,7 +1516,12 @@ function calcs.initEnv(build, mode, override, specEnv)
end
-- if the slot has an imbued support, add it as an ExtraSupport
if build.skillsTab.imbuedSupportBySlot and build.skillsTab.imbuedSupportBySlot[slotName] and group.imbuedSupport then
addExtraSupports(nil, build.skillsTab.imbuedSupportBySlot[slotName], 1)
local imbuedSupport = build.skillsTab.imbuedSupportBySlot[slotName]
addExtraSupports(nil, imbuedSupport, 1)
local imbuedGemData = env.data.gems[env.data.gemForSkill[imbuedSupport]]
if imbuedGemData and imbuedGemData.secondaryGrantedEffect and imbuedGemData.secondaryGrantedEffect.support then
addExtraSupports(nil, imbuedGemData.secondaryGrantedEffect, 1)
end
end

for gemIndex, gemInstance in ipairs(group.gemList) do
Expand Down
Loading