Fix crash on selecting some Imbued gems + trigger supports not working#9793
Merged
LocalIdentity merged 2 commits intodevfrom Apr 20, 2026
Merged
Fix crash on selecting some Imbued gems + trigger supports not working#9793LocalIdentity merged 2 commits intodevfrom
LocalIdentity merged 2 commits intodevfrom
Conversation
added 2 commits
April 20, 2026 22:24
Support gems like Prismatic Burst of Summon Wisps are not valid imbued supports as they grant active skills
Secondary granted effects from supports like cast on crit or cast when damage taken weren't working as we were not adding the secondary granted effects
LocalIdentity
added
bug: calculation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Fixes the crash that occurred when an imbued support tried to grant a active skill
Fixes imbued supports that granted a secondary granted effect like cast on crit, cast when damage taken or cast while channeling
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: