Skip to content

fix(ci): E2E gate must verify work actually ran, not just top-level success #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pimlock merged 1 commit into from
Apr 23, 2026
Merged

fix(ci): E2E gate must verify work actually ran, not just top-level success #926

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions .github/workflows/e2e-gate-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,18 +84,30 @@ jobs:
exit 1
fi

run_id=$(jq -r '.id' <<< "$latest")
status=$(jq -r '.status' <<< "$latest")
conclusion=$(jq -r '.conclusion' <<< "$latest")

if [ "$conclusion" = "success" ]; then
echo "$WORKFLOW_FILE succeeded for $HEAD_SHA."
exit 0
fi

if [ "$status" != "completed" ]; then
echo "::error::$WORKFLOW_FILE is $status for $HEAD_SHA. This gate will re-evaluate on completion."
exit 1
fi

echo "::error::$WORKFLOW_FILE concluded as $conclusion for $HEAD_SHA."
exit 1
if [ "$conclusion" != "success" ]; then
echo "::error::$WORKFLOW_FILE concluded as $conclusion for $HEAD_SHA."
exit 1
fi

# Top-level success isn't enough: if `pr_metadata` gated downstream
# jobs out (label wasn't set at run time), only the gate job itself
# concludes `success` and the workflow still reports `success`.
# Require at least one non-gate job to have succeeded as proof the
# label was present when the workflow ran.
real_success=$(gh api "repos/$GH_REPO/actions/runs/$run_id/jobs" --jq '[.jobs[] | select(.conclusion == "success" and .name != "Resolve PR metadata")] | length')
if [ "$real_success" -lt 1 ]; then
echo "::error::$WORKFLOW_FILE run $run_id only ran the metadata gate — $REQUIRED_LABEL was not set when the workflow last executed. Re-run $WORKFLOW_FILE so the gate re-evaluates with the label present."
exit 1
fi

echo "$WORKFLOW_FILE run $run_id executed and succeeded for $HEAD_SHA ($real_success non-gate job(s) passed)."
exit 0
Loading