fix(ci): E2E gate must verify work actually ran, not just top-level success#926
Merged
fix(ci): E2E gate must verify work actually ran, not just top-level success#926
Conversation
…uccess The gate passed whenever `Branch E2E Checks` (or `GPU Test`) concluded `success` for the head SHA. But when the required label wasn't set at the time of the run, `pr_metadata` gates downstream jobs out, every non-gate job is `skipped`, and the workflow still reports `success`. Result: labeling a PR after the workflow already ran left the gate green even though E2E never executed. Now also query the run's jobs and require at least one non-gate (`name != "Resolve PR metadata"`) job to have concluded `success`. If only the gate job itself succeeded, fail with an actionable message asking the maintainer to re-run the workflow so the gate re-evaluates with the label in place. Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
TaylorMutch
approved these changes
Apr 23, 2026
4 tasks
maxamillion
added a commit
to maxamillion/OpenShell
that referenced
this pull request
Apr 23, 2026
…dman # By Piotr Mlocek (2) and Drew Newberry (1) # Via GitHub * upstream/main: fix(ci): e2e gate must verify work actually ran, not just top-level success (NVIDIA#926) fix(driver-vm): preflight supervisor cross-compile toolchain in start.sh (NVIDIA#931) feat(server,driver-vm,e2e): gateway-owned readiness + VM compute driver e2e (NVIDIA#901) # Conflicts: # crates/openshell-server/src/compute/mod.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes gap in
E2E Gatediscovered while testing #922 in PR #924: labeling a PR afterBranch E2E Checksalready ran (with the label absent) kept the gate green, because the gate only checked the workflow's top-levelconclusion.When
pr_metadatareturnsshould_run=false, every downstream job (build-gateway,build-cluster, the E2E matrix) isskipped— so the workflow top-level concludessuccesseven though nothing was actually tested. The gate was treating that as a pass.Change
In
.github/workflows/e2e-gate-check.yml, after verifying top-level success, also query the run's jobs and require at least one job other thanResolve PR metadatato have concludedsuccess. If only the gate job succeeded, the gate fails with an actionable message.Using "at least one non-gate success" instead of "zero skipped jobs" so legitimate conditional skips in future jobs don't break the gate.
Testing
gh api .../actions/runs/<id>/jobsagainst the existing no-label run on PR test: verify copy-pr-bot + E2E Gate flow (do not merge) #924 that the job list showsResolve PR metadata=successand the three downstream jobs asskipped— the new check correctly countsreal_success=0and would fail.E2E Gateon test: verify copy-pr-bot + E2E Gate flow (do not merge) #924 via theworkflow_runtrigger; expected flip from green → red becausetest:e2eis labeled there but the underlyingBranch E2E Checksrun only executed the gate.Checklist