fix: use string comparison in if conditions#37
Merged
IlyaKhD merged 1 commit intoDevExpress:mainfrom Apr 16, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates conditional logic in the install-internal-package composite GitHub Action to correctly handle string-typed inputs in if: expressions.
Changes:
- Change
if:checks forinstall-distfrom truthy evaluation to explicit string comparison (== 'true') for the download and validation steps.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alexslavr
force-pushed
the
lavrov/boolean-inputs
branch
from
2573a6f to
b2b7486
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
IlyaKhD
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Inputs passed as a strings, so the only correct way to use them is a string comparison