Skip to content

fix: replace package installation with files copying#36

Merged
alexslavr merged 3 commits intoDevExpress:mainfrom
IlyaKhD:khd/npmi
Apr 16, 2026
Merged

fix: replace package installation with files copying#36
alexslavr merged 3 commits intoDevExpress:mainfrom
IlyaKhD:khd/npmi

Conversation

@IlyaKhD
Copy link
Copy Markdown
Contributor

@IlyaKhD IlyaKhD commented Apr 15, 2026

Practical Value

This is required to avoid using unsafe npm i

Before

After

@IlyaKhD IlyaKhD self-assigned this Apr 15, 2026
Copilot AI review requested due to automatic review settings April 15, 2026 13:45
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the install-internal-package composite GitHub Action to avoid npm i for internal packages by downloading tarballs and replacing the already-installed package contents directly from the .tgz.

Changes:

  • Add a Node script that removes the current installed package directory and extracts a packed .tgz into its place.
  • Update the action to call the new replacement script instead of running npm i <pkg>@<tgz>.
  • Tighten the find command to only search the current directory for the downloaded tarball.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
install-internal-package/replace-package.js New script to delete the existing package directory and extract the internal tarball into place.
install-internal-package/action.yml Switch install steps from npm i ...@<tgz> to node replace-package.js ... <tgz> and constrain tarball discovery to -maxdepth 1.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread install-internal-package/action.yml
Comment thread install-internal-package/replace-package.js Outdated
Comment thread install-internal-package/replace-package.js Outdated
Comment thread install-internal-package/replace-package.js Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread install-internal-package/action.yml
Comment thread install-internal-package/replace-package.js
Comment thread install-internal-package/replace-package.js
Comment thread install-internal-package/action.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants