Fixed discovery#263
Draft
rekby wants to merge 2 commits into
Draft
Conversation
- New Internal\Discovery that always targets the original bootstrap endpoint and recreates the gRPC channel with force_new on retries, so c-core re-resolves DNS and recovers from bootstrap IP changes. - New config keys: discoveryTimeoutMs (5000), discoveryAttemptTimeoutMs (1000), discoveryInitialTimeoutMs (PHP_INT_MAX). - Default grpc.lb_policy_name = round_robin in Ydb::grpcOpts() (user can override via grpc.opts.grpc.lb_policy_name). - Fixed array_search cluster-endpoint check in Ydb::discover() (returning key 0 was treated as "not found"); replaced with strict in_array. - Unit tests in tests/Internal/DiscoveryTest.php.
The advisory (CVE-2026-6409, DoS via malicious messages) affects every google/protobuf <4.33.6, i.e. the whole 3.x line we currently depend on via "~3.15.8". Composer 2.7+ refuses to install such packages by default, which blocks CI. Adding "config.policy.advisories.ignore-id" so install proceeds. The proper fix (bumping google/protobuf to a non-vulnerable major) is being done separately in #260 and will land in the next release; this ignore should be removed at that point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and recreates the gRPC channel with force_new on retries, so c-core
re-resolves DNS and recovers from bootstrap IP changes.
discoveryInitialTimeoutMs (PHP_INT_MAX).
override via grpc.opts.grpc.lb_policy_name).
0 was treated as "not found"); replaced with strict in_array.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information