Skip to content

Feat/checker verbosity#56

Open
xross wants to merge 1 commit into
xmos:developfrom
xross:feat/checker_verbosity
Open

Feat/checker verbosity#56
xross wants to merge 1 commit into
xmos:developfrom
xross:feat/checker_verbosity

Conversation

@xross
Copy link
Copy Markdown
Contributor

@xross xross commented May 28, 2026

ComparisonChecker only prints expected output when verbosity > 1

so with the intended usage, -v gives:

OUTPUT: CONTROLLER START condition
OUTPUT: CONTROLLER Sending direct CCC 0x90 to device 0x3C
OUTPUT: CONTROLLER Broadcast address 0x7E-W |byte: 0xFC|
OUTPUT: CONTROLLER Sending data 0xFC
...

-vv gives:

GOLDEN: CONTROLLER START condition
OUTPUT: CONTROLLER START condition
GOLDEN: CONTROLLER Sending direct CCC 0x90 to device 0x3C
OUTPUT: CONTROLLER Sending direct CCC 0x90 to device 0x3C
GOLDEN: CONTROLLER Broadcast address 0x7E-W |byte: 0xFC|
OUTPUT: CONTROLLER Broadcast address 0x7E-W |byte: 0xFC|
GOLDEN: CONTROLLER Sending data 0xFC
OUTPUT: CONTROLLER Sending data 0xFC
...

@xross xross force-pushed the feat/checker_verbosity branch from afcecec to d04e3f4 Compare May 28, 2026 13:41
@xross xross requested a review from Copilot May 28, 2026 15:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts ComparisonTester verbosity behavior so normal verbose mode prints only actual output, while higher verbosity also prints golden/expected output.

Changes:

  • Prints GOLDEN: lines only when verbosity is greater than 1.
  • Keeps OUTPUT: lines printed when verbosity is greater than 0.
  • Adds a changelog entry for the verbosity behavior change.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
lib/python/Pyxsim/testers.py Updates verbose comparison output gating for expected vs actual lines.
CHANGELOG.rst Documents the changed verbosity behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread CHANGELOG.rst Outdated
@xross xross requested a review from humphrey-xmos May 28, 2026 15:24
@xross xross force-pushed the feat/checker_verbosity branch from d04e3f4 to a97187a Compare May 28, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants