Skip to content

Remove SQLite from continue-on-error in functional tests#240

Merged
swissspidy merged 2 commits intomainfrom
copilot/remove-allowed-to-fail-sqlite-tests
Apr 21, 2026
Merged

Remove SQLite from continue-on-error in functional tests#240
swissspidy merged 2 commits intomainfrom
copilot/remove-allowed-to-fail-sqlite-tests

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 21, 2026

SQLite compatibility across WP-CLI repositories has matured to the point where SQLite test failures should be treated as real failures rather than silently ignored.

Change

Drops inputs.dbtype == 'sqlite' from the continue-on-error expression in reusable-functional.yml:

# Before
continue-on-error: ${{ inputs.dbtype == 'sqlite' || inputs.dbtype == 'mariadb' || inputs.php == 'nightly' || startsWith( inputs.os, 'windows' ) || startsWith( inputs.os, 'macos' ) }}

# After
continue-on-error: ${{ inputs.dbtype == 'mariadb' || inputs.php == 'nightly' || startsWith( inputs.os, 'windows' ) || startsWith( inputs.os, 'macos' ) }}

SQLite runs will now block on failure like standard MySQL runs. MariaDB, PHP nightly, Windows, and macOS remain as allowed-to-fail.

Copilot AI changed the title [WIP] Remove allowed to fail status for SQLite tests Remove SQLite from continue-on-error in functional tests Apr 21, 2026
Copilot AI requested a review from swissspidy April 21, 2026 08:16
@swissspidy swissspidy marked this pull request as ready for review April 21, 2026 08:27
@swissspidy swissspidy requested a review from a team as a code owner April 21, 2026 08:27
Copilot AI review requested due to automatic review settings April 21, 2026 08:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the reusable functional GitHub Actions workflow so SQLite functional test failures are no longer treated as allowed-to-fail, reflecting improved SQLite compatibility across WP-CLI repositories.

Changes:

  • Removes inputs.dbtype == 'sqlite' from the continue-on-error expression in the functional test job.
  • Keeps existing allowed-to-fail conditions for MariaDB, PHP nightly, Windows, and macOS.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@swissspidy swissspidy merged commit 42f1b41 into main Apr 21, 2026
15 checks passed
@swissspidy swissspidy deleted the copilot/remove-allowed-to-fail-sqlite-tests branch April 21, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request scope:testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not mark SQLite tests as allowed to fail anymore

3 participants