Remove SQLite from continue-on-error in functional tests#240
Merged
swissspidy merged 2 commits intomainfrom Apr 21, 2026
Merged
Remove SQLite from continue-on-error in functional tests#240swissspidy merged 2 commits intomainfrom
continue-on-error in functional tests#240swissspidy merged 2 commits intomainfrom
Conversation
….yml Agent-Logs-Url: https://github.com/wp-cli/.github/sessions/c2338a32-1f4d-4bcf-aa76-a498a247f1b4 Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove allowed to fail status for SQLite tests
Remove SQLite from Apr 21, 2026
continue-on-error in functional tests
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the reusable functional GitHub Actions workflow so SQLite functional test failures are no longer treated as allowed-to-fail, reflecting improved SQLite compatibility across WP-CLI repositories.
Changes:
- Removes
inputs.dbtype == 'sqlite'from thecontinue-on-errorexpression in the functional test job. - Keeps existing allowed-to-fail conditions for MariaDB, PHP nightly, Windows, and macOS.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLite compatibility across WP-CLI repositories has matured to the point where SQLite test failures should be treated as real failures rather than silently ignored.
Change
Drops
inputs.dbtype == 'sqlite'from thecontinue-on-errorexpression inreusable-functional.yml:SQLite runs will now block on failure like standard MySQL runs. MariaDB, PHP nightly, Windows, and macOS remain as allowed-to-fail.