fix: dkms.conf WOLFSSL_ROOT and kernel 8.x support#17
fix: dkms.conf WOLFSSL_ROOT and kernel 8.x support#17MarkAtwood wants to merge 1 commit intowolfSSL:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes DKMS build configuration to correctly pass WOLFSSL_ROOT (with a sensible default) and updates supported kernel version matching to include 8.x; also adds documentation for DKMS usage. Additionally, this PR introduces Beads/Dolt and Claude agent configuration files, which appears unrelated to the DKMS fixes described.
Changes:
- Update
dkms.confto passWOLFSSL_ROOTinto the DKMSmakeinvocation and extendBUILD_EXCLUSIVE_KERNELto match 8.x. - Document DKMS setup and the
/usr/src/wolfsslconvention (plus override) inREADME.md. - Add Beads/Dolt repo metadata, hooks, and Claude/agent configuration; update
.gitignoreaccordingly.
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| kernel-src/dkms.conf | Passes WOLFSSL_ROOT into DKMS builds; expands supported kernel regex to 8.x. |
| README.md | Adds DKMS usage docs and documents WOLFSSL_ROOT override. |
| CLAUDE.md | Adds AI agent workflow/tooling instructions (Beads). |
| AGENTS.md | Adds agent instructions and repeats Beads integration guidance. |
| .gitignore | Ignores Dolt/Beads artifacts (but uses broad *.db). |
| .claude/settings.json | Adds Claude hooks to run bd prime automatically. |
| .beads/** | Adds Beads configuration, metadata, docs, hooks, and ignore patterns. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| DEST_MODULE_LOCATION="/wolfssl" | ||
|
|
||
| MAKE="make -j module" | ||
| MAKE="make -j WOLFSSL_ROOT=${WOLFSSL_ROOT:-/usr/src/wolfssl} module" |
There was a problem hiding this comment.
WOLFSSL_ROOT is injected without quoting, so paths containing spaces (or shell-sensitive characters) will break DKMS builds. Quote the assignment so the value is passed as a single make variable (e.g., WOLFSSL_ROOT="...") while keeping the default fallback behavior.
| MAKE="make -j WOLFSSL_ROOT=${WOLFSSL_ROOT:-/usr/src/wolfssl} module" | |
| MAKE="make -j WOLFSSL_ROOT=\"${WOLFSSL_ROOT:-/usr/src/wolfssl}\" module" |
| # requires kernel 3.10 - 7.x, inclusive: | ||
| BUILD_EXCLUSIVE_KERNEL="^(([7654]\.)|(3\.1[0-9]))" | ||
| # requires kernel 3.10 - 8.x, inclusive: | ||
| BUILD_EXCLUSIVE_KERNEL="^(([87654]\.)|(3\.1[0-9]))" |
There was a problem hiding this comment.
The regex is inconsistent: the major-version branch includes a \. but the 3\.1[0-9] branch does not. Adding a trailing \. to the 3.10–3.19 branch (e.g., 3\.1[0-9]\.) makes the intent clearer and avoids accidental matches on longer prefixes.
| BUILD_EXCLUSIVE_KERNEL="^(([87654]\.)|(3\.1[0-9]))" | |
| BUILD_EXCLUSIVE_KERNEL="^(([87654]\.)|(3\.1[0-9]\.))" |
| { | ||
| "database": "dolt", | ||
| "backend": "dolt", | ||
| "dolt_mode": "embedded", | ||
| "dolt_database": "wolfguard", | ||
| "project_id": "9f17adae-2663-4f93-a3e8-4a774052e480" | ||
| } No newline at end of file |
There was a problem hiding this comment.
The PR description/title focus on DKMS + kernel 8.x support, but the diff also introduces Beads/Dolt metadata, hooks, and Claude/agent configuration across multiple new files. This is a significant scope expansion; either split Beads/agent tooling into a separate PR or update the PR description (and possibly title) to explicitly include that tooling change and its rationale.
Pass WOLFSSL_ROOT to make so DKMS builds can find the wolfssl tree. Defaults to /usr/src/wolfssl; overridable via environment. Extend BUILD_EXCLUSIVE_KERNEL regex to cover kernel 8.x. Add DKMS usage section to README.md.
MarkAtwood
force-pushed
the
fix/dkms-wolfssl-root-kernel8
branch
from
6746714 to
8521b09
Compare
Summary
dkms.confMAKEcommand never passedWOLFSSL_ROOT, so DKMS builds always failed at link time. Now defaults to/usr/src/wolfssl; overridable via environment variable.BUILD_EXCLUSIVE_KERNELregex only matched kernels 3–7; extended to include 8.x.README.mddocumenting the/usr/src/wolfsslconvention and theWOLFSSL_ROOToverride.Test plan
dkms add kernel-src/with wolfssl at/usr/src/wolfssl— verify build succeedsWOLFSSL_ROOT=/custom/path dkms install wolfguard/<version>— verify override is respecteddkms statusreports module installed on a kernel 8.x system