Merged
Conversation
JacobBarthelmeh
requested changes
Apr 17, 2026
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds Yocto/BitBake support for building wolfSSL “FIPS Ready” variants, including a kernel module recipe and integration toggles for dependent components.
Changes:
- Introduces new
wolfssl-fips-readyandwolfssl-linuxkm-fips-readyrecipes plus a sample configuration file. - Extends libgcrypt/GnuTLS/wolfProvider integration to accept
wolfssl-fips-readyas a valid provider and applies required compile flags. - Updates example image gating and docs to describe using the new FIPS Ready provider.
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| recipes-wolfssl/wolfssl/wolfssl-linuxkm-fips-ready.bb | New recipe to build/package the FIPS Ready kernel module and optionally auto-embed a FIPS hash. |
| recipes-wolfssl/wolfssl/wolfssl-fips-ready.bb | New recipe to build the FIPS Ready userspace wolfSSL from a bundle. |
| recipes-wolfssl/wolfprovider/wolfssl-fips-ready.bbappend | Enables wolfProvider-related configuration when using the FIPS Ready provider. |
| recipes-support/libgcrypt/libgcrypt_%.bbappend | Allows wolfssl-fips-ready as a provider for the libgcrypt integration include. |
| recipes-support/gnutls/wolfssl-gnutls-wrapper_git.bb | Adds a FIPS Ready-specific compile define needed by the wrapper build. |
| recipes-examples/wolfprovider/wolfprovidertest/files/wolfprovidertest.sh | Adjusts test script to locate the provider library by adding a symlink in the expected directory. |
| recipes-core/images/wolfssl-linux-fips-images/fips-image-minimal/wolfssl-fips-ready.bbappend | Image-specific config includes for FIPS Ready plus a stamp-h.in workaround. |
| recipes-core/images/wolfssl-linux-fips-images/fips-image-minimal/fips-image-minimal.bb | Permits either wolfssl-fips or wolfssl-fips-ready providers for the minimal FIPS image. |
| inc/wolfssl-fips-ready/wolfssl-enable-libgcrypt.inc | Selects modern vs legacy include for libgcrypt integration. |
| inc/wolfssl-fips-ready/wolfssl-enable-libgcrypt-modern.inc | Adds FIPS Ready/libgcrypt configure flags and defines (modern). |
| inc/wolfssl-fips-ready/wolfssl-enable-libgcrypt-legacy.inc | Adds FIPS Ready/libgcrypt configure flags and defines (legacy). |
| inc/wolfssl-fips-ready/wolfssl-enable-gnutls.inc | Selects modern vs legacy include for GnuTLS integration. |
| inc/wolfssl-fips-ready/wolfssl-enable-gnutls-modern.inc | Adds FIPS Ready/GnuTLS configure flags and defines (modern). |
| inc/wolfssl-fips-ready/wolfssl-enable-gnutls-legacy.inc | Adds FIPS Ready/GnuTLS configure flags and defines (legacy). |
| inc/wolfprovider/wolfssl-enable-wolfprovider-fips-ready.inc | Selects modern vs legacy include for wolfProvider integration. |
| inc/wolfprovider/wolfssl-enable-wolfprovider-fips-ready-modern.inc | Enables wolfProvider + drops a marker file for FIPS Ready builds (modern). |
| inc/wolfprovider/wolfssl-enable-wolfprovider-fips-ready-legacy.inc | Enables wolfProvider + drops a marker file for FIPS Ready builds (legacy). |
| inc/libgcrypt/scarthgap/libgcrypt-enable-wolfssl-modern.inc | Selects a suitable libgcrypt-wolfssl branch and adds a FIPS Ready AES macro mapping. |
| inc/gnutls/scarthgap/gnutls-enable-wolfssl-modern.inc | Extends FIPS enablement logic to include wolfssl-fips-ready. |
| conf/wolfssl-fips-ready.conf.sample | Adds a sample local.conf fragment for configuring a FIPS Ready bundle build. |
| README.md | Replaces the old link to a separate FIPS-Ready README with an in-tree “Using wolfssl-fips-ready” section. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JacobBarthelmeh
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working PR on needed recipes to run fips ready builds