Skip to content

Wire_Render performance improvement#3584

Merged
Astralcircle merged 10 commits intowiremod:masterfrom
thegrb93:patch-1
Apr 15, 2026
Merged

Wire_Render performance improvement#3584
Astralcircle merged 10 commits intowiremod:masterfrom
thegrb93:patch-1

Conversation

@thegrb93
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread lua/wire/client/cl_wirelib.lua Outdated
Comment thread lua/wire/client/cl_wirelib.lua Outdated
@thegrb93
Copy link
Copy Markdown
Contributor Author

Not tested btw

@Astralcircle
Copy link
Copy Markdown
Contributor

Astralcircle commented Apr 15, 2026

I made some more optimizations/styling of the code, i think it's now fine (tested, works fine)

@thegrb93
Copy link
Copy Markdown
Contributor Author

thegrb93 commented Apr 15, 2026

Ok, just make sure to give a quick test to make sure it doesn't error

Comment thread lua/wire/client/cl_wirelib.lua
@thegrb93
Copy link
Copy Markdown
Contributor Author

I went ahead and replaced the blink timer as well since it'll only be calculated for one entity given by the ent_GetNWString. I think the ent_GetNWString is a bug btw. It should probably be ent_GetNWBool

@Astralcircle
Copy link
Copy Markdown
Contributor

I went ahead and replaced the blink timer as well since it'll only be calculated for one entity given by the ent_GetNWString. I think the ent_GetNWString is a bug btw. It should probably be ent_GetNWBool

Yes, this is a mistake, it should be GetNWBool, or even better, do it through NW2

@Astralcircle
Copy link
Copy Markdown
Contributor

It turns out this isn't even a networked value, it's only set on the client

@thegrb93
Copy link
Copy Markdown
Contributor Author

I see how it works actually, it was getting set to the port name to blink.

@Astralcircle
Copy link
Copy Markdown
Contributor

Also fixed the issue where the wires weren't blinking after changing from a timer to a check in the rendering function

@Astralcircle Astralcircle merged commit a1fbc9e into wiremod:master Apr 15, 2026
1 check passed
@thegrb93 thegrb93 deleted the patch-1 branch April 15, 2026 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants