fix: also suppress readdir EACCES/EINVAL on the watched directory (#187)#298
Merged
alexander-akait merged 3 commits intomainfrom Apr 28, 2026
Merged
Conversation
The lstat error path in `doScan` already swallows `EACCES`/`EPERM`/`EBUSY` and `EINVAL` (Windows) so unreadable entries inside a watched parent (e.g. `pagefile.sys` under `/mnt/c` on WSL) don't print "Watchpack Error (initial scan)". Mirror the same set in the `readdir` error handler so an unreadable directory itself is treated as removed instead of logging. Adds regression tests covering both the lstat and readdir paths for `EACCES`/`EPERM`, with the `EINVAL` variants gated to Windows where the suppression actually applies.
Adds `ENODEV` to the list of error codes treated as "missing" / "directory removed" in `doScan`. Closes the gap reported by CumpsD in #187: Watchpack Error (initial scan): Error: ENODEV: no such device, lstat '/efi' `ENODEV` surfaces when an entry exists but its underlying device is gone (unmounted, ejected, or never mounted), which is the same operational situation as `ENOENT`/`EPERM` from watchpack's perspective: we can't inspect the entry, so don't log noise — just treat it as gone. Tests extended to cover ENODEV in both the lstat and readdir paths.
🦋 Changeset detectedLatest commit: 74bd5ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #298 +/- ##
==========================================
+ Coverage 95.77% 95.87% +0.10%
==========================================
Files 7 7
Lines 1183 1189 +6
Branches 346 352 +6
==========================================
+ Hits 1133 1140 +7
+ Misses 45 44 -1
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #187