Update API format and support multiple string/pre-extracted inputs#11
Merged
danmichaeljones merged 4 commits intomainfrom Mar 19, 2026
Merged
Update API format and support multiple string/pre-extracted inputs#11danmichaeljones merged 4 commits intomainfrom
danmichaeljones merged 4 commits intomainfrom
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
augustas1
reviewed
Mar 19, 2026
| if isinstance(content, StringContent): | ||
| return {"type": "string", "content": content.content} | ||
| if isinstance(content.content, list): | ||
| return {"string": {"content": content.content}} |
Collaborator
There was a problem hiding this comment.
feels like content inside content.
Maybe all our dataclasses should be renamed to input, and content would refer only to the atomic part (the actual texts)?
Contributor
Author
There was a problem hiding this comment.
Good shout - I've renamed content to input throughout so that content now only refers to the inner fields. I also updated the .add() arg/type alias to input_data: AddInput to match (but not shadow input builtin)
added 2 commits
March 19, 2026 12:33
augustas1
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update serialisation to use new API input format and support multiple string/pre-extracted inputs.
StringContenthas been extended to also supportcontent: list[str]PreExtractedContentcontainslist[PreExtractedItem].