You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Remove the no-op curl_close($ch) call in Pay\Adapter that triggers a Deprecated notice on PHP 8.5.
Why
curl_close() has been a no-op since PHP 8.0 and is now formally deprecated in 8.5. The curl handle is freed when the variable goes out of scope.
Test plan
composer lint (Pint) — pass
composer check (PHPStan) — pre-existing failure on main unrelated to this change (pinned phpstan/phpstan: 1.9.x-dev is incompatible with PHP 8.4's stricter ReflectionClassConstant::IS_PUBLIC type signature). Repo CI does not run PHPStan.
Removes the curl_close($ch) call in Adapter::call() that has been a no-op since PHP 8.0 and is formally deprecated in PHP 8.5. The curl handle is already freed automatically when $ch goes out of scope at function return, so this change is correct and has no behavioral impact.
Confidence Score: 5/5
Safe to merge — single-line removal of a known no-op; no behavioral change.
The change is a well-understood, correct removal of a deprecated no-op API call with no side effects. No logic is altered.
No files require special attention.
Important Files Changed
Filename
Overview
src/Pay/Adapter.php
Removes the no-op curl_close($ch) call that is deprecated in PHP 8.5; curl handle is freed automatically on scope exit.
Superseded by full migration to utopia-php/fetch (raw curl removed entirely, including this curl_close line). Closing in favor of the migration PR opening on a fresh branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
curl_close($ch)call inPay\Adapterthat triggers aDeprecatednotice on PHP 8.5.Why
curl_close()has been a no-op since PHP 8.0 and is now formally deprecated in 8.5. The curl handle is freed when the variable goes out of scope.Test plan
composer lint(Pint) — passcomposer check(PHPStan) — pre-existing failure onmainunrelated to this change (pinnedphpstan/phpstan: 1.9.x-devis incompatible with PHP 8.4's stricterReflectionClassConstant::IS_PUBLICtype signature). Repo CI does not run PHPStan.