Skip to content

Feat: Param aliases#53

Merged
ChiragAgg5k merged 3 commits intomasterfrom
feat-param-alias
May 5, 2026
Merged

Feat: Param aliases#53
ChiragAgg5k merged 3 commits intomasterfrom
feat-param-alias

Conversation

@Meldiron
Copy link
Copy Markdown
Contributor

@Meldiron Meldiron commented May 4, 2026

No description provided.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 4, 2026

Greptile Summary

  • Adds alias resolution to CLI::getParams() so that short-form flags like --e are resolved to the canonical param (email) when the canonical key is absent from parsed args; the logic is correct and priority order (canonical → first matching alias → default) is sound.
  • Test coverage for the alias feature verifies the happy path but does not cover canonical-overrides-alias (both --email and --e supplied) or the default-fallback-when-no-alias-matches scenario.
  • Dependency versions are all pinned to stable tagged releases (utopia-php/servers 0.4.0, utopia-php/di 0.3.2, utopia-php/validators 0.2.2), resolving the dev-branch concern from the previous review round.

Confidence Score: 5/5

Safe to merge — the alias resolution logic is correct and dependencies are pinned to stable releases.

No P0 or P1 issues found. The core fix in getParams() correctly implements the alias fallback chain, the test validates the primary use case, and all dependencies now reference tagged versions.

No files require special attention.

Important Files Changed

Filename Overview
src/CLI/CLI.php Alias resolution correctly added to getParams() — falls back to aliases array when canonical key is absent from parsed args
tests/CLI/CLITest.php New testParamAliases covers the basic alias path but lacks coverage for canonical-wins-over-alias and alias-with-default-fallback edge cases
composer.json utopia-php/servers bumped to stable 0.4.0 (was pinned to dev branch in earlier iteration), utopia-php/di to 0.3.2, utopia-php/validators to 0.2.2
composer.lock Lock file updated consistently with composer.json version bumps; all references point to tagged releases

Reviews (3): Last reviewed commit: "Use stable servers 0.4.0" | Re-trigger Greptile

Comment thread composer.json Outdated
@ChiragAgg5k ChiragAgg5k merged commit 3c45ae5 into master May 5, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants