Fix/raps chiefs view

[bsedwards]

Adding new Chiefs view as selectable view for a RAPS role

Summary by CodeRabbit

• New Features
  • Added support for retrieving VMTH Chiefs member information from an additional data source, expanding member lookup capabilities.

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)

• review-ready

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 71f39557-e314-4cda-8625-ee3a16d965fb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

📝 Walkthrough

Walkthrough

New VwVmthChief model class added to support the vw_VMTH_Chiefs database view. Entity Framework context configured with DbSet and keyless view mapping. GetViewMembers service method updated to handle the new view name and return member IDs from the mapped DbSet.

Changes

vw_VMTH_Chiefs View Integration

Layer / File(s)	Summary
Data Model Definition web/Models/RAPS/VwVmthChief.cs	New VwVmthChief partial class with nullable MemberId string property.
Entity Framework Configuration web/Classes/SQLContext/RAPSContext.cs	Added VwVmthChiefs DbSet property and OnModelCreating configuration mapping VwVmthChief as a keyless entity to the vw_VMTH_Chiefs view with column mappings.
Service Method Integration web/Areas/RAPS/Services/RoleViews.cs	GetViewMembers switch case added for vw_vmth_chiefs view name to query and return member IDs from VwVmthChiefs DbSet.

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly references the main change: adding a new Chiefs view to the RAPS role system, which aligns with the PR objectives.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/raps-chiefs-view

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov-commenter]

Bundle Report

Bundle size has no change ✅

[codecov-commenter]

Codecov Report

❌ Patch coverage is 14.45783% with 71 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.96%. Comparing base (858333b) to head (af44382).

Files with missing lines	Patch %	Lines
web/Areas/RAPS/Services/RoleViews.cs	0.00%	70 Missing ⚠️
web/Models/RAPS/VwVmthChief.cs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
+ Coverage   42.95%   42.96%   +0.01%     
==========================================
  Files         876      877       +1     
  Lines       51454    51468      +14     
  Branches     4802     4802              
==========================================
+ Hits        22101    22113      +12     
- Misses      28829    28831       +2     
  Partials      524      524              

Flag	Coverage Δ
backend	43.04% <14.45%> (+0.01%)	⬆️
frontend	41.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rlorenzo]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@web/Areas/RAPS/Services/RoleViews.cs`:
- Line 215: This read-only EF Core query for the "vw_vmth_chiefs" case is
missing AsNoTracking; update the expression that uses _RAPSContext.VwVmthChiefs
(the lambda returning MemberId) to call .AsNoTracking() on the DbSet before
.Select(...) so the query becomes a no-tracking read and avoids unnecessary
change tracking overhead.

In `@web/Models/RAPS/VwVmthChief.cs`:
- Line 3: Remove the unnecessary partial modifier from the class declaration:
change "public partial class VwVmthChief" to "public class VwVmthChief" in the
VwVmthChief type so the class is no longer declared partial (there is only one
part), resolving the ReSharper warning.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 93a9d5b6-a47e-4780-ba32-b05f55f521b0

📥 Commits

Reviewing files that changed from the base of the PR and between 858333b and c56a318.

📒 Files selected for processing (3)

• web/Areas/RAPS/Services/RoleViews.cs
• web/Classes/SQLContext/RAPSContext.cs
• web/Models/RAPS/VwVmthChief.cs