[MRG] docs: Fixes #378 — restore 'Running tests locally' in CONTRIBUTING.md#672
Open
jbbqqf wants to merge 1 commit into
Open
[MRG] docs: Fixes #378 — restore 'Running tests locally' in CONTRIBUTING.md#672jbbqqf wants to merge 1 commit into
jbbqqf wants to merge 1 commit into
Conversation
…earn-team#378) Issue tslearn-team#378 reports that CONTRIBUTING.md no longer documents how to run the tests locally — an important first step for new contributors. This adds a focused subsection right before the Pull Request Checklist with: - creating a venv and editable install, - running the full pytest suite from tests/, - running a single file / single test, - running doctests for a module, - a one-liner about optional extras. The rest of the document is unchanged.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #672 +/- ##
=======================================
Coverage 93.70% 93.70%
=======================================
Files 73 73
Lines 6986 6986
=======================================
Hits 6546 6546
Misses 440 440 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Hi @jbbqqf and thanks for your PR, glad to welcome you onboard. The documentation also includes a contributing section (docs/contributing.rst) and could benefit from the same treatment. Do you think this PR can be adapted to handle both concerns? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores a "Running the test suite locally" subsection to
CONTRIBUTING.mdso new contributors know how to verify their changes before opening a PR. Issue #378 reports that this guidance was lost during a previous CONTRIBUTING update.Fixes #378 — Contributing.MD no longer contains instructions to run tests locally.
Context
The current
CONTRIBUTING.mdwalks new contributors through forking, branching and pushing, but never tells them which command runs the tests or where the tests live. New contributors hitting the file have to grep the repo (or guesspytest) before they can validate a fix locally — exactly the friction the original issue raised.The added section sits right before the existing Pull Request Checklist (which already says "Bug-fixes or new features should be provided with non-regression tests" but doesn't say how to run them), so the two pieces of guidance now flow together.
Changes
CONTRIBUTING.md— added a### Running the test suite locallysubsection covering:tslearn+pytest,pytest tests/suite from the repo root,pytest tests/test_metrics.py::test_dtw -v),pytest --doctest-modules tslearn/metrics/dtw_variants.py),h5py,tensorflow,torch).Documentation-only — no behavioural change.
Reproduce BEFORE/AFTER yourself (copy-paste)
What I ran locally
pytest tests/against the new instructions to confirm the documented commands actually run on a clean editable install. Passing locally.CONTRIBUTING.md— section sits before Pull Request Checklist; existing structure preserved.Edge cases tested
git diff --statCONTRIBUTING.mdmodifiedgit diffCONTRIBUTING.mdRisk / blast radius
Documentation-only — zero runtime impact.
Release note
PR drafted with assistance from Claude Code. The reproducer block above was used during development; it is the same one a reviewer can paste verbatim.