rvs: Introduce pod pending reason#243
rvs: Introduce pod pending reason#243Jakob-Naucke wants to merge 1 commit intotrusted-execution-clusters:mainfrom
Conversation
Jakob-Naucke
force-pushed
the
backoff-approved-image
branch
from
d43f6e6 to
32874bf
Compare
Jakob-Naucke
force-pushed
the
backoff-approved-image
branch
from
32874bf to
1f5a7d1
Compare
| Ok(pod_list.iter().any(|pod| { | ||
| pod.status | ||
| .as_ref() | ||
| .and_then(|s| s.phase.as_ref()) | ||
| .is_some_and(|phase| phase == "Pending") | ||
| })) |
There was a problem hiding this comment.
could have a mixture of pod in error state and pending? Should we simply take the latest created
There was a problem hiding this comment.
good catch, PTAL
to avoid misleading "computation is ongoing" reason when e.g. image pull fails. Watching for image and pod events within one reconciliation has some gotchas, so requeue if computing or pending. Fixes: trusted-execution-clusters#241 Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
Jakob-Naucke
force-pushed
the
backoff-approved-image
branch
from
1f5a7d1 to
57f6d65
Compare
|
@Jakob-Naucke: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alicefr, Jakob-Naucke The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@Jakob-Naucke do you want to merge this or we wait for the CI? |
|
prefer waiting for CI |
2 participants
to avoid misleading "computation is ongoing" reason when e.g. image pull fails. Watching for image and pod events within one reconciliation has some gotchas, so requeue if computing or pending.
Fixes: #241