Write test collection bundle metadata into uploads#1089
Open
dfrankland wants to merge 9 commits into
Open
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1089 +/- ##
==========================================
+ Coverage 81.75% 82.04% +0.28%
==========================================
Files 69 69
Lines 14917 14939 +22
==========================================
+ Hits 12195 12256 +61
+ Misses 2722 2683 -39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TylerJang27
approved these changes
May 11, 2026
Comment on lines
+27
to
+30
| #[serde(rename = "testCollectionBundleMetaId")] | ||
| pub test_collection_bundle_meta_id: Option<String>, | ||
| #[serde(rename = "testCollectionBundleMetaCreatedAt")] | ||
| pub test_collection_bundle_meta_created_at: Option<String>, |
TylerJang27
approved these changes
May 12, 2026
dfrankland
commented
May 12, 2026
Comment on lines
+6
to
+13
| #[serde(rename_all = "camelCase")] | ||
| pub struct CreateBundleUploadRequest { | ||
| pub repo: RepoUrlParts, | ||
| #[serde(rename = "orgUrlSlug")] | ||
| pub org_url_slug: String, | ||
| #[serde(rename = "clientVersion")] | ||
| pub client_version: String, | ||
| #[serde(rename = "remoteUrls")] | ||
| pub remote_urls: Vec<String>, | ||
| #[serde(rename = "externalId")] | ||
| pub external_id: Option<String>, | ||
| pub test_collection_short_id: Option<String>, |
Member
Author
There was a problem hiding this comment.
Not sure why we were doing the conversion by hand. Serde makes it easy
dfrankland
commented
May 12, 2026
Comment on lines
+48
to
+49
| #[serde(flatten, default)] | ||
| pub test_collection: Option<TestCollectionProps>, |
Member
Author
There was a problem hiding this comment.
I'm putting this directly in the base props because:
- this is backwards compatible
- base props are the easiest to access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testCollectionShortIdduring upload init and accept prefixed canonical test-collection bundle metadata fields in the responsetest_collection_bundle_meta_idandtest_collection_bundle_meta_created_atinto bundle metadata only for test-collection uploadsTesting
cargo test -p trunk-analytics-cli upload_bundle -- --nocapture