Skip to content

dev: extract tls optional before blocking thread#1429

Closed
da2ce7 wants to merge 1 commit intotorrust:developfrom
da2ce7:20250403_block_on_only_for_tls
Closed

dev: extract tls optional before blocking thread#1429
da2ce7 wants to merge 1 commit intotorrust:developfrom
da2ce7:20250403_block_on_only_for_tls

Conversation

@da2ce7
Copy link
Copy Markdown
Contributor

@da2ce7 da2ce7 commented Apr 3, 2025

No description provided.

@josecelano
Copy link
Copy Markdown
Member

Superseded by #1735

@josecelano josecelano closed this May 6, 2026
josecelano added a commit that referenced this pull request May 7, 2026
…1429)

ddb4cfb fix(bootstrap): extract optional TLS config before make_rust_tls (Cameron Garnham)

Pull request description:

  ## Summary
  - supersede old PR #1429 by replaying its intent on top of current `develop`
  - make `make_rust_tls` receive a concrete `TslConfig`
  - unwrap optional TLS config at call sites before invoking `make_rust_tls`

  ## Why
  PR #1429 no longer applies cleanly to current `develop`. This PR carries the same behavioral intent while resolving code drift in current call sites.

  ## Validation
  - `cargo test -p torrust-axum-server -p torrust-axum-http-tracker-server -p torrust-axum-rest-tracker-api-server`

ACKs for top commit:
  josecelano:
    ACK ddb4cfb

Tree-SHA512: a110f1c32e9741f0f3631cd686872bc6a8418d2148dbb7c38797be043b9435820d292682277aa5baa3ee818039f4d477ee4f891a6a87399eda18861544564a2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Rebase Base Branch has Incompatibilities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix bug related to the crate tracing-test for writing assertions for logs

2 participants