CI: invoke Apalache via apalache-mc.bat (and cmd.exe) on Windows#210
Draft
CI: invoke Apalache via apalache-mc.bat (and cmd.exe) on Windows#210
Conversation
`tla_utils.check_model` hard-coded `bin/apalache-mc`, but on Windows
the launcher is `bin/apalache-mc.bat` and `subprocess.run` cannot
spawn `.bat` files via CreateProcess directly. Resolve the launcher
per-platform and route batch files through `cmd.exe /c`.
This was latent because the only symbolic-mode model in CI
(EinsteinRiddle) was always being skipped: `[ ${{ matrix.unicode }} ]`
in CI.yml is truthy for both "true" and "false", so the SKIP entry
was added unconditionally rather than only on the Unicode variant.
Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tla_utils.check_modelhard-codedbin/apalache-mc, but on Windows the launcher isbin/apalache-mc.batandsubprocess.runcannot spawn.batfiles via CreateProcess directly. Resolve the launcher per-platform and route batch files throughcmd.exe /c. This was latent because the only symbolic-mode model in CI (EinsteinRiddle) was always being skipped:[ ${{ matrix.unicode }} ]in CI.yml is truthy for both "true" and "false", so the SKIP entry was added unconditionally rather than only on the Unicode variant.