ci(govulncheck): bump v1.1.1 -> v1.1.4 to unblock Go 1.25 toolchain#19
Merged
Conversation
govulncheck v1.1.1 transitively imports golang.org/x/tools@v0.21.1,
which contains an array-length trick in internal/tokeninternal/tokeninternal.go:64
that evaluates to -256 on Go 1.25 and fails to compile:
invalid array length -delta * delta (constant -256 of type int64)
This blocks any dep bump that pushes go.mod past go 1.24.0 (e.g. PR #11's
golang.org/x/time v0.15.0, which requires go 1.25.0).
govulncheck v1.1.4 uses x/tools v0.29.0, which doesn't have that pattern.
v1.1.4 still requires only Go 1.22.0 minimum, so it works on both Go 1.24
(current main) and Go 1.25 (post-#11). Holding back from v1.2.0 because
v1.2.0+ requires Go 1.25.0 minimum, which would prematurely force the
toolchain floor before consumers are ready.
Pairs with #18's gotestsum v1.12.0 -> v1.13.0 bump for the same
underlying issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #18, same root cause.
`govulncheck v1.1.1` transitively imports `golang.org/x/tools@v0.21.1`, whose `internal/tokeninternal/tokeninternal.go:64` contains an array-length trick that evaluates to `-256` on Go 1.25 and fails to compile:
```
invalid array length -delta * delta (constant -256 of type int64)
```
This blocks any dep bump that pushes `go.mod` past `go 1.24.0`. PR #11 (golang.org/x/time v0.15.0) is the immediate trigger — its bump forces `go 1.25.0`. PR #18 already fixed the same issue for `gotestsum` (v1.12.0 → v1.13.0); this is the matching fix for the other `go install`-managed CI tool.
Why v1.1.4 specifically
Verification
Test plan