-
Notifications
You must be signed in to change notification settings - Fork 213
Signal links #2889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Evanthx
wants to merge
17
commits into
master
Choose a base branch
from
signal-links
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Signal links #2889
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
772725d
First pass at adding links for signalling
Evanthx 9ce8f8e
Progress
Evanthx f15d07b
Added some tests
Evanthx dbe83c4
First pass at adding links for signalling
Evanthx 2b77d24
Progress
Evanthx 76ceb24
Added some tests
Evanthx 75cf03f
Merge remote-tracking branch 'refs/remotes/origin/signal-links' into …
Evanthx 68db323
Pin proto submodule to standalone-nexus-op branch for signal-backlink…
Evanthx 3cd5940
Update temporal-sdk/src/main/java/io/temporal/internal/nexus/Internal…
Evanthx 8ef91ec
Renamed methods to remove the word signal
Evanthx 921a910
Renamed a few more methods from Signal to Backlinks
Evanthx 480d289
Adding a Nexus link converter helper method
Evanthx fbfb3c4
Code review results
Evanthx 41e0240
Added a comment
Evanthx 85d5ed4
Some changes for PR comments
Evanthx b97939a
Restoring try try block
Evanthx e84b784
Removed cross-namespace test
Evanthx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this belongs in this PR, this probably belongs in the SANO PR, BUT the server doesn't support SANO links right now so the SDK can't send them yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may not have detected the lack of server support because this change doesn't exercise SANO, another reason this change doesn't belong in this PR