ci: add workflow permissions and update vulnerable dependencies#2388
Open
yonib05 wants to merge 2 commits into
Open
ci: add workflow permissions and update vulnerable dependencies#2388yonib05 wants to merge 2 commits into
yonib05 wants to merge 2 commits into
Conversation
- Add permissions: {} to ci-gate job (needs no token access)
- Add permissions: contents: read, issues: write to
check-links job (reads repo, may create issues)
- Bump aws-cdk-lib from 2.192.0 to 2.257.0 in CDK example projects (resolves minimatch, yaml, ajv, fast-uri, brace-expansion advisories) - Run npm update on root and site package-lock.json (resolves qs advisory)
yonib05
force-pushed
the
fix/workflow-permissions-and-deps
branch
from
a2984c1 to
2d74cb8
Compare
Contributor
|
Assessment: Approve Clean and well-scoped security hardening PR. The workflow permission declarations follow the principle of least privilege correctly ( Review Notes
Straightforward security improvement — LGTM. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
zastrowm
approved these changes
May 29, 2026
Contributor
Documentation Preview ReadyYour documentation preview has been successfully deployed! Preview URL: https://d3ehv1nix5p99z.cloudfront.net/pr-cms-2388/docs/user-guide/quickstart/overview/ Updated at: 2026-05-29T18:36:50.319Z |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
permissions:declarations to jobs missing them (ci-gatein ci.yml,check-linksin python-check-markdown-links.yml)aws-cdk-libfrom 2.192.0 to 2.257.0 in all CDK example projects to resolve transitive dependency vulnerabilities (minimatch, yaml, ajv, fast-uri, brace-expansion)package-lock.jsonto resolveqsadvisoryTest plan
permissions: {}is correct)