Skip to content

feat(strands-py-wasm): make variant arms inherit from container#2386

Merged
chaynabors merged 1 commit into
mainfrom
feature/variant-arm-inheritance
May 29, 2026
Merged

feat(strands-py-wasm): make variant arms inherit from container#2386
chaynabors merged 1 commit into
mainfrom
feature/variant-arm-inheritance

Conversation

@chaynabors
Copy link
Copy Markdown
Member

@chaynabors chaynabors commented May 29, 2026

Hey Chay, wanted to chat about pgrayy/wasm-deps@983c56c#diff-e4f544b88abae11d378b0216c10391b30e49ef793d62aa21dd66abdc445517beR301

One thing I noticed is that since the arms only inherit from _WitVariantCase, we can't really use the parent class as a type on our end. This means that things like isinstance checks or referencing in type signatures don't work because there's no inheritance relationship between the arms and the parent.

Fixed.

@chaynabors chaynabors changed the title feat(strands-py-wasm): variant arms inherit from container; tighten init typing feat(strands-py-wasm): make variant arms inherit from container May 29, 2026
@chaynabors chaynabors enabled auto-merge (squash) May 29, 2026 17:16
@yonib05 yonib05 added the area-community Related to community and contributor health label May 29, 2026
@yonib05 yonib05 added enhancement New feature or request python Pull requests that update python code labels May 29, 2026
@chaynabors chaynabors merged commit a1ad62b into main May 29, 2026
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-community Related to community and contributor health enhancement New feature or request python Pull requests that update python code size/xl

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants