chore: sync strands-agents/sdk-typescript into monorepo#2363
Conversation
Co-authored-by: Strands Agent <217235299+strands-agent@users.noreply.github.com>
Co-authored-by: Gautam Sirdeshmukh <gsird@amazon.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Assessment: Approve Clean monorepo sync — the hand-written changes (CI wiring, Review Notes
No blocking issues found. |
Merge latest typescript/main (3 commits): - fix: revert MCP from JSON to update node imports (strands-agents#1113) - feat(wit): align type names with TS SDK (strands-agents#1107) - feat: add per-invocation limits (turns / outputTokens / totalTokens) (strands-agents#1106) Conflict resolutions: - AGENTS.md: keep monorepo version (ours) - typescript-pr-and-push.yml: keep workflow_call (ours), incorporate new wasm-* paths and call-py-check job (theirs) - strands-py-wasm/pyproject.toml: take git URL for pgrayy-wasmtime (theirs), keep botocore dep (ours) - ci.yml: add .github/workflows/wasm-* to typescript path filter
59090d1 to
8163b0c
Compare
|
Assessment: Comment (one minor fix needed) Clean monorepo sync. The single actionable issue is a missing Review Notes
|
- Format strands-py-wasm/_runtime.py with ruff - Add missing || github.sha fallback for call-py-check ref
b1442d0 to
6285901
Compare
|
Assessment: Approve Clean monorepo sync with well-structured hand-written code. No blocking issues found. Review NotesNote on prior review comments: The earlier automated reviews flagged a "missing ref: ${{ github.event.pull_request.head.sha || github.sha }}This appears to have been corrected between force-pushes. No bug exists in the current code. strands-py diff: The branch-to-main diff shows Code quality observations:
|
|
Assessment: Request Changes This PR silently reverts the Python SDK Review Details
The TS SDK and Python WASM surface changes look great — just need clarity on the Python SDK limits revert. |
Caution
DO NOT squash or rebase — this must be merged with a merge commit to preserve commit history.
Description
Sync the latest
strands-agents/sdk-typescriptcommits into the monorepo. Three new commits since the initial TypeScript merge (#2350):fix: revert MCP from JSON to update node imports (#1113)feat(wit): align type names with TS SDK (#1107)feat: add per-invocation limits (turns / outputTokens / totalTokens) (#1106)No new commits on
strands-agents/docssince the docs merge.Conflict resolutions:
typescript-pr-and-push.ymlworkflow_call(ours), add newwasm-*paths andcall-py-checkjob (theirs)strands-py-wasm/pyproject.tomlci.yml.github/workflows/wasm-*to typescript path filterRelated Issues
#2286
Documentation PR
N/A
Type of Change
Other (please describe): Monorepo sync — merging upstream TypeScript SDK commits.
Testing
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.