feat(a2a): add agent_card_url property to A2AServer for customizable url in AgentCard#2003
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
21cfc64 to
adfdded
Compare
|
Assessment: Comment The feature addresses a real use case (decoupling the advertised AgentCard URL from the internal server URL for reverse-proxy/load-balancer deployments). The implementation is clean and follows the existing Review Details
Overall, a small well-scoped change with good test coverage. |
|
The integration test failures are due to external API quota/auth issues (Anthropic API limit exhausted, Mistral API auth invalid, OpenAI web search config) and are not related to the code changes in this PR. These are pre-existing infrastructure issues. The code review is complete and approved by @JackYPCOnline — just awaiting final approval from another reviewer per branch protection rules. |
…ble `url` in `AgentCard`
adfdded to
9d4ee8a
Compare
Head branch was pushed to by a user without write access
Description
A2AServercurrently sets theurlfield in theAgentCardtohttp_url, which always appends a trailing slash. In load-balanced or reverse-proxy deployments, the advertised URL may need to differ from the internalhttp_url- for example, to omit the trailing slash or use a completely different base URL.This PR adds an
agent_card_urlproperty toA2AServerthat defaults tohttp_urlbut can be overridden via a setter, giving users control over the URL advertised in theAgentCard.Related Issues
No related issues.
Documentation PR
To be created after approval
Type of Change
New feature
Testing
Yes, I have tested the change and verified it doesn't break functionality.
hatch run prepareChecklist
Use Cases
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.