Skip to content

feat: config overrides#818

Open
dervoeti wants to merge 7 commits intomainfrom
feat/config-overrides
Open

feat: config overrides#818
dervoeti wants to merge 7 commits intomainfrom
feat/config-overrides

Conversation

@dervoeti
Copy link
Copy Markdown
Member

@dervoeti dervoeti commented Mar 18, 2026

Description

Fixes #756

This PR implements typed configOverrides for the OPA operator. Users can now override settings on OPA's config file config.json using JSON merge patch or JSON patches or do a full file replacement.

Upgraded stackable-operator from 0.108.0 to 0.110.1.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@dervoeti
Copy link
Copy Markdown
Member Author

Release note

The OPA operator now supports configOverrides, which allow users to easily override settings in OPA's config.json.

@dervoeti dervoeti self-assigned this Mar 19, 2026
@dervoeti dervoeti moved this to Development: Waiting for Review in Stackable Engineering Mar 19, 2026
@sbernauer sbernauer self-requested a review March 19, 2026 08:07
@dervoeti dervoeti moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Mar 19, 2026
Comment thread rust/operator-binary/src/controller.rs Outdated
Comment thread rust/operator-binary/src/controller.rs Outdated
Comment thread rust/operator-binary/src/controller.rs Outdated
Comment thread docs/modules/opa/pages/usage-guide/configuration-environment-overrides.adoc Outdated
Comment thread docs/modules/opa/pages/usage-guide/OpenTelemetry.adoc
sbernauer
sbernauer previously approved these changes Apr 8, 2026
Copy link
Copy Markdown
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! Now we only need stackabletech/operator-rs#1177 ;)

Comment thread docs/modules/opa/pages/usage-guide/configuration-environment-overrides.adoc Outdated
@dervoeti dervoeti force-pushed the feat/config-overrides branch 2 times, most recently from 0ae5cc3 to 3fb65bf Compare April 17, 2026 10:08
@dervoeti dervoeti force-pushed the feat/config-overrides branch from 3fb65bf to 44c2a91 Compare April 17, 2026 10:26
@dervoeti dervoeti requested a review from sbernauer April 17, 2026 10:26
.with_service_scope(rolegroup_ref.rolegroup_metrics_service_name())
.build()
.context(TlsVolumeBuildSnafu)?,
// OPA needs the full TLS keypair (public cert + private key) to serve HTTPS.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls move that line above SecretClassVolumeProvisionParts::PublicPrivate

}),
)
.to_volume(USER_INFO_FETCHER_KERBEROS_VOLUME_NAME)
// The user-info-fetcher needs both the keytab (private) and the Kerberos config (public).
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls move that line above SecretClassVolumeProvisionParts::PublicPrivate

Comment thread CHANGELOG.md

### Changed

- Bump `stackable-operator` to 0.110.0 and `snafu` to 0.9 ([#818]).
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Bump `stackable-operator` to 0.110.0 and `snafu` to 0.9 ([#818]).
- Bump `stackable-operator` to 0.110.1 and `snafu` to 0.9 ([#818]).

Comment thread flake.nix
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have flake.nix and flake.lock been added intentionally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: In Review

Development

Successfully merging this pull request may close these issues.

Support configOverrides for config.json

2 participants