Skip to content

feat: Implement generic database connection#814

Open
maltesander wants to merge 22 commits intomainfrom
feat/generic-database-connection
Open

feat: Implement generic database connection#814
maltesander wants to merge 22 commits intomainfrom
feat/generic-database-connection

Conversation

@maltesander
Copy link
Copy Markdown
Member

@maltesander maltesander commented Apr 21, 2026

Description

Part of stackabletech/issues#238
Needs stackabletech/operator-rs#1200

  • BREAKING: renamed metadata_storage_database -> metadata_database (consolidation)
  • remove metadata storage database properties from product config properties yaml

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@maltesander maltesander self-assigned this Apr 21, 2026
@maltesander maltesander added release-note Denotes a PR that will be considered when it comes time to generate release notes. release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. labels Apr 21, 2026
@maltesander maltesander moved this to Development: In Progress in Stackable Engineering Apr 21, 2026
@maltesander maltesander marked this pull request as ready for review April 21, 2026 14:03
@maltesander maltesander moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Apr 21, 2026
@maltesander maltesander requested a review from sbernauer April 21, 2026 14:14
@sbernauer
Copy link
Copy Markdown
Member

I will have a look after stackabletech/superset-operator#722

Copy link
Copy Markdown
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Comment thread rust/operator-binary/src/crd/database.rs Outdated
Comment thread rust/operator-binary/src/crd/database.rs Outdated
Comment thread dev-cluster.yml
Comment thread CHANGELOG.md Outdated
Comment thread Cargo.toml
[patch."https://github.com/stackabletech/operator-rs.git"]
# stackable-operator = { path = "../operator-rs/crates/stackable-operator" }
# stackable-operator = { git = "https://github.com/stackabletech//operator-rs.git", branch = "main" }
stackable-operator = { git = "https://github.com/stackabletech//operator-rs.git", branch = "feat/derby-host-part" }
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marker

Comment thread tests/templates/kuttl/external-access/50_druid.yaml.j2 Outdated
Comment thread rust/operator-binary/src/crd/mod.rs Outdated
Comment on lines +802 to +804
todo!(
"Return some test data according to https://stackabletech.github.io/operator-rs/stackable_versioned/test_utils/trait.RoundtripTestData.html"
)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marker

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats left here then?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed as 72a21a2

stackable-bot and others added 5 commits April 24, 2026 07:34
* chore: Generated commit to update templated files since the last template run up to stackabletech/operator-templating@a39137c

Reference-to: stackabletech/operator-templating@a39137c (Part of stackabletech/issues#716)

* chore(helm): Remove image.repository from values.yaml

---------

Co-authored-by: Techassi <git@techassi.dev>
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
…se-connection' into feat/generic-database-connection
@maltesander maltesander requested a review from sbernauer April 24, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

Status: Development: Waiting for Review

Development

Successfully merging this pull request may close these issues.

3 participants