Detect COUNT(*) function alias in QueryUtils.#4249
Open
config25 wants to merge 1 commit intospring-projects:mainfrom
Open
Detect COUNT(*) function alias in QueryUtils.#4249config25 wants to merge 1 commit intospring-projects:mainfrom
config25 wants to merge 1 commit intospring-projects:mainfrom
Conversation
Include the asterisk character in the FUNCTION_PATTERN argument character class so that the COUNT(*) AS <alias> form is detected by QueryUtils.getFunctionAliases. Without this, DefaultQueryEnhancer's applySorting prefixes the alias with the root entity alias and produces invalid SQL such as ORDER BY u.cnt instead of ORDER BY cnt. Closes spring-projects#4242 Signed-off-by: Young-ho Kim <yhkim052556@naver.com>
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include the asterisk character in the
FUNCTION_PATTERNargumentcharacter class so that the
COUNT(*) AS <alias>form is detected byQueryUtils.getFunctionAliases.Without this,
DefaultQueryEnhancer.applySortingprefixes the aliaswith the root entity alias and produces invalid SQL such as
ORDER BY u.cntinstead ofORDER BY cnt.Adds a regression test (
discoversCountStarFunctionAlias) covering theissue's reproducer and the GROUP BY example from the issue body.
Closes #4242