Fix Document.isText() media type handling and add test coverage#5892
Open
karansahani78 wants to merge 1 commit intospring-projects:mainfrom
Open
Fix Document.isText() media type handling and add test coverage#5892karansahani78 wants to merge 1 commit intospring-projects:mainfrom
karansahani78 wants to merge 1 commit intospring-projects:mainfrom
Conversation
Signed-off-by: karansahani78 <119734907+karansahani78@users.noreply.github.com>
9d80b57 to
d9902d1
Compare
Author
|
This PR is related to #5600. Based on the ongoing discussion there, it seems introducing a clearer distinction for “textual media” may be preferred over modifying I’m keeping this PR as a reference for the current approach, but I’m happy to refactor it (e.g. introduce a helper like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve handling of media types in Document.isText()
Previously, certain text-based media types were not correctly identified as text.
This change improves the detection logic to properly handle such cases.
Additionally, a new test class (DocumentIsTextMediaTest) has been added to
verify correct behavior across different media types.