Upgrade Core and Blaze

[jviotti]

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

[cubic-dev-ai]

1 issue found across 252 files

Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed. cubic prioritises the most important files to review.

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/ir/ir.cc">

<violation number="1" location="src/ir/ir.cc:113">
P1: Skipping all descendants under `contains`/`propertyNames` can drop schemas that are still referenced via `$ref`, leading to generated aliases that reference non-emitted types.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

P1: Skipping all descendants under contains/propertyNames can drop schemas that are still referenced via $ref, leading to generated aliases that reference non-emitted types.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At src/ir/ir.cc, line 113:

<comment>Skipping all descendants under `contains`/`propertyNames` can drop schemas that are still referenced via `$ref`, leading to generated aliases that reference non-emitted types.</comment>

<file context>
@@ -67,6 +108,12 @@ auto compile(const sourcemeta::core::JSON &input,
 
+    // Skip subschemas under validation-only keywords that do not contribute
+    // to the type structure (like `contains`)
+    if (is_validation_subschema(frame, location, walker, resolver)) {
+      continue;
+    }
</file context>

[augmentcode]

🤖 Augment PR Summary

Summary: This PR upgrades the vendored Sourcemeta Core dependency and introduces Sourcemeta Blaze as a new dependency, updating Codegen’s build/packaging and IR pipeline accordingly.

Changes:

• Updated DEPENDENCIES to a newer Core revision and added a new Blaze dependency (vendored under vendor/blaze).
• Extended CI and the local Makefile install flow to install Blaze runtime/dev components alongside Core and Codegen.
• Switched schema canonicalization from sourcemeta::core::alterschema to sourcemeta::blaze::alterschema, and updated CMake packaging to require Blaze’s alterschema component.
• Added IR support for allOf via a new IRIntersection node and updated the TypeScript generator to emit intersection type aliases.
• Improved IR compilation by skipping subschemas that are under validation-only keywords (e.g. contains), reducing generation of non-structural types.
• Updated IR and TypeScript E2E tests to reflect the new allOf/reference behavior and symbol emission.

Technical Notes: This upgrade notably changes the dependency graph (Core no longer provides alterschema here), and introduces a large vendored Blaze subtree that must be compatible with the project’s distribution/licensing expectations.

_{🤖 Was this summary useful? React with 👍 or 👎}

[augmentcode]

Review completed. 3 suggestions posted.

Comment augment review to trigger a new review at any time.

[augmentcode]

FindBlaze.cmake sets SOURCEMETA_BLAZE_INSTALL, but the vendored Blaze CMake uses BLAZE_INSTALL to gate install rules/components; this looks like CODEGEN_INSTALL may not actually control Blaze’s install behavior as intended.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

[augmentcode]

handle_allof doesn’t guard against an empty allOf array; in that case it would return an IRIntersection with no branches, which then causes the TypeScript generator to emit an invalid export type X =\n; definition.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

[augmentcode]

This PR vendors Blaze under an AGPLv3-or-later / commercial dual license; can you confirm the intended licensing/compliance story for distributing Codegen (and any CI artifacts) with this new vendored dependency?

Severity: high

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}