Skip to content

[CLD-1916]: feat(solana): port MaybeLoadMCMSWithTimelockState#12

Merged
graham-chainlink merged 2 commits intomainfrom
ggoh/cld-1916/solana-loadstate-2
Apr 23, 2026
Merged

[CLD-1916]: feat(solana): port MaybeLoadMCMSWithTimelockState#12
graham-chainlink merged 2 commits intomainfrom
ggoh/cld-1916/solana-loadstate-2

Conversation

@graham-chainlink
Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ports Solana support for loading MCMS+Timelock deployment state across multiple chain selectors, aligning this repo’s Solana family helpers with the upstream Chainlink implementation.

Changes:

  • Added MaybeLoadMCMSWithTimelockState(env, chainSelectors) to load Solana MCMS+Timelock state per chain selector from the datastore.
  • Added unit tests covering empty inputs, multi-chain isolation, and invalid address error wrapping.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
pkg/family/solana/state.go Introduces the multi-chain state loader that iterates selectors and delegates to the existing per-chain loader.
pkg/family/solana/state_test.go Adds test coverage for the new multi-chain loader and a local test environment helper.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pkg/family/solana/state.go Outdated
Comment thread pkg/family/solana/state.go Outdated
@graham-chainlink graham-chainlink force-pushed the ggoh/cld-1916/solana-loadstate-2 branch from 62574ba to c5b44e0 Compare April 23, 2026 06:07
@graham-chainlink graham-chainlink marked this pull request as ready for review April 23, 2026 06:17
@graham-chainlink graham-chainlink requested a review from a team as a code owner April 23, 2026 06:17
Copilot AI review requested due to automatic review settings April 23, 2026 06:17
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ports MaybeLoadMCMSWithTimelockState into the Solana family state helpers so callers can load MCMS+Timelock bindings for multiple Solana chain selectors from the environment datastore.

Changes:

  • Added MaybeLoadMCMSWithTimelockState(env, chainSelectors) to load per-chain Solana MCMS+Timelock state from datastore address refs.
  • Added unit tests covering empty input, per-chain isolation, and wrapped error behavior on invalid addresses.
  • Added a small Solana test environment helper for constructing a cldf.Environment with an in-memory datastore.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
pkg/family/solana/state.go Adds multi-chain-selector state loader wrapper around MaybeLoadMCMSWithTimelockChainState.
pkg/family/solana/state_test.go Adds tests for the new multi-chain loader and a helper to build a minimal Solana test environment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pkg/family/solana/state.go Outdated
@graham-chainlink graham-chainlink force-pushed the ggoh/cld-1916/solana-loadstate-2 branch from c5b44e0 to 167ebad Compare April 23, 2026 06:21
Copilot AI review requested due to automatic review settings April 23, 2026 07:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ports Solana MCMS-with-Timelock state-loading helpers (and supporting accessors) into this repo to load per-chain Solana deployment state from the datastore.

Changes:

  • Added MaybeLoadMCMSWithTimelockState to load MCMSWithTimelockState for multiple Solana chain selectors.
  • Added MCMSWithTimelockPrograms helpers (GetStateFromType, SetState, RoleAccount) to read/write program/seed/account state by contract/role type.
  • Added comprehensive unit tests covering multi-chain loading and the new helper methods.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
pkg/family/solana/state.go Adds multi-chain state loader and new MCMSWithTimelockPrograms helper methods.
pkg/family/solana/state_test.go Adds tests for the new multi-chain loader and the helper methods.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pkg/family/solana/state.go
Comment thread pkg/family/solana/state.go
@graham-chainlink graham-chainlink enabled auto-merge (squash) April 23, 2026 12:31
@graham-chainlink graham-chainlink merged commit d3a752a into main Apr 23, 2026
14 checks passed
@graham-chainlink graham-chainlink deleted the ggoh/cld-1916/solana-loadstate-2 branch April 23, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants