bugfix(python): Use a cross platform file locking package instead of …#574
Open
ian-sift wants to merge 5 commits into
Open
bugfix(python): Use a cross platform file locking package instead of …#574ian-sift wants to merge 5 commits into
ian-sift wants to merge 5 commits into
Conversation
Contributor
|
Python docs preview: https://sift-stack.github.io/sift/python/pr-574/ Deployed from |
ian-sift
force-pushed
the
cross-plat-filelock
branch
from
50105e3 to
d72f43c
Compare
Drops the install-python-windows job and instead adds a `mypy --platform=win32 lib` step to the existing test-python job on ubuntu-latest. The Windows job only existed to surface platform-gated stub regressions like `import fcntl`; mypy with --platform=win32 picks up the same class of issues from typeshed without paying for a Windows runner. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI passes (also verified locally w/ 3.8)
added windows lint that catches this bug https://github.com/sift-stack/sift/actions/runs/26117219960/job/76809547350?pr=575