chore: allow any Node 24.x patch version in engines#1949
Open
klodr wants to merge 1 commit into
Open
Conversation
Loosens engines.node from a pinned 24.x.x to ^24, so contributors on any Node 24 release line can install without manual override. Signed-off-by: Valentin (Developer Digital) <valentin@klodr.digital> Co-authored-by: Claude Perrin <klodr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
engines.nodeis currently pinned to the exact patch version24.12.0. Contributors on any other 24.x patch release (24.10,24.13, etc.) get a hard
EBADENGINEerror fromyarn installand have to either downgrade Node or pass
--ignore-enginestowork around it.
The pin offers no real reproducibility benefit since the same
lockfile applies to every 24.x release; it just adds friction.
What
Replace the exact pin with
^24, accepting any Node 24 release.yarn installstill produces an identical dependency graph (thelockfile is unchanged); only the engines check loosens.
"engines": { - "node": "24.12.0" + "node": "^24" }Test plan
yarn installon Node 24.10 / 24.12 / 24.13 → succeedswithout
--ignore-engines.actions/setup-node, so the engines value is advisory there).