Skip to content

fix #127 - feat: Implement Storybook structure and styling#151

Merged
ricardozanini merged 13 commits into
serverlessworkflow:mainfrom
cheryl7114:storybook-styling-127
May 27, 2026
Merged

fix #127 - feat: Implement Storybook structure and styling#151
ricardozanini merged 13 commits into
serverlessworkflow:mainfrom
cheryl7114:storybook-styling-127

Conversation

@cheryl7114
Copy link
Copy Markdown
Contributor

@cheryl7114 cheryl7114 commented May 19, 2026

Closes #127

Description
This PR implements the following changes to Storybook:

  • Colour theme selector (light and dark mode trigger)
  • Folder restructuring
  • Set up Storybook tests
  • Collapsible sections: Introduction, Use Cases, Features
  • Remove boilerplate code
  • Document features research for potential future implementation

Copilot AI review requested due to automatic review settings May 19, 2026 10:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR streamlines the serverless-workflow-diagram-editor package’s Storybook setup by removing the default Storybook “Example” boilerplate components/docs and aligning the remaining stories under a Features/* hierarchy with corrected source import paths.

Changes:

  • Removed Storybook starter boilerplate (Button/Header/Page components, CSS, and Configure docs MDX).
  • Reorganized remaining stories under Features/* titles for clearer navigation.
  • Fixed story imports to reference the package src/ from the stories/features/ directory (e.g., ../../src/...).

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/serverless-workflow-diagram-editor/stories/Page.tsx Removed Storybook starter “Page” boilerplate component.
packages/serverless-workflow-diagram-editor/stories/Page.stories.ts Removed Storybook starter “Page” story (incl. interaction test).
packages/serverless-workflow-diagram-editor/stories/page.css Removed CSS used only by the deleted starter “Page”.
packages/serverless-workflow-diagram-editor/stories/Header.tsx Removed Storybook starter “Header” boilerplate component.
packages/serverless-workflow-diagram-editor/stories/Header.stories.ts Removed Storybook starter “Header” story.
packages/serverless-workflow-diagram-editor/stories/header.css Removed CSS used only by the deleted starter “Header”.
packages/serverless-workflow-diagram-editor/stories/Configure.mdx Removed Storybook starter Configure docs page.
packages/serverless-workflow-diagram-editor/stories/Button.tsx Removed Storybook starter “Button” boilerplate component.
packages/serverless-workflow-diagram-editor/stories/Button.stories.ts Removed Storybook starter “Button” story.
packages/serverless-workflow-diagram-editor/stories/button.css Removed CSS used only by the deleted starter “Button”.
packages/serverless-workflow-diagram-editor/stories/features/ErrorPage.stories.tsx Updated imports to ../../src/... and renamed story title to Features/ErrorPage.
packages/serverless-workflow-diagram-editor/stories/features/DiagramEditorDragNDrop.tsx Updated import path to ../../src/diagram-editor/DiagramEditor.
packages/serverless-workflow-diagram-editor/stories/features/DiagramEditorDragNDrop.stories.ts Renamed story title to Features/Diagram-Editor-Drag-N-Drop.
packages/serverless-workflow-diagram-editor/stories/features/DiagramEditor.tsx Updated import path to ../../src/diagram-editor/DiagramEditor.
packages/serverless-workflow-diagram-editor/stories/features/DiagramEditor.stories.ts Renamed story title to Features/Diagram-Editor.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings May 21, 2026 15:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.

Copilot AI review requested due to automatic review settings May 25, 2026 09:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 24 out of 25 changed files in this pull request and generated 8 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Comment thread packages/serverless-workflow-diagram-editor/vitest.config.ts
Comment thread packages/serverless-workflow-diagram-editor/package.json Outdated
Comment thread packages/serverless-workflow-diagram-editor/package.json Outdated
Comment thread packages/serverless-workflow-diagram-editor/stories/README.md Outdated
Comment thread packages/serverless-workflow-diagram-editor/stories/README.md Outdated
@cheryl7114 cheryl7114 changed the title Refactor Storybook structure and remove boilerplate code fix #127 - feat: Implement Storybook structure and styling May 25, 2026
Copilot AI review requested due to automatic review settings May 25, 2026 10:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 24 out of 25 changed files in this pull request and generated 4 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Comment thread packages/serverless-workflow-diagram-editor/vitest.config.ts
Comment thread packages/serverless-workflow-diagram-editor/package.json Outdated
Copy link
Copy Markdown
Member

@fantonangeli fantonangeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Just 2 small suggestions
Thanks @cheryl7114

Comment thread packages/serverless-workflow-diagram-editor/package.json Outdated
Comment thread packages/serverless-workflow-diagram-editor/package.json Outdated
Cheryl Kong added 6 commits May 26, 2026 12:40
Signed-off-by: Cheryl Kong <cherylkong50@gmail.com>
Signed-off-by: Cheryl Kong <cherylkong50@gmail.com>
Signed-off-by: Cheryl Kong <cherylkong50@gmail.com>
Signed-off-by: Cheryl Kong <cherylkong50@gmail.com>
Signed-off-by: Cheryl Kong <cherylkong50@gmail.com>
Signed-off-by: Cheryl Kong <cherylkong50@gmail.com>
@cheryl7114 cheryl7114 force-pushed the storybook-styling-127 branch from 36b47dd to a7d09e8 Compare May 26, 2026 11:47
@netlify
Copy link
Copy Markdown

netlify Bot commented May 26, 2026

Deploy Preview for swf-editor ready!

Name Link
🔨 Latest commit 9909c31
🔍 Latest deploy log https://app.netlify.com/projects/swf-editor/deploys/6a17065ca48b780007fffa22
😎 Deploy Preview https://deploy-preview-151--swf-editor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@fantonangeli
Copy link
Copy Markdown
Member

@ricardozanini our Netlify configuration is working 🚀

Signed-off-by: Cheryl Kong <cherylkong50@gmail.com>
Copilot AI review requested due to automatic review settings May 26, 2026 13:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Signed-off-by: Cheryl Kong <cherylkong50@gmail.com>
Copilot AI review requested due to automatic review settings May 26, 2026 13:44
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

…e support

Signed-off-by: Cheryl Kong <cherylkong50@gmail.com>
Copilot AI review requested due to automatic review settings May 26, 2026 15:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copy link
Copy Markdown
Contributor

@kumaradityaraj kumaradityaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cheryl7114 cheryl7114 requested a review from fantonangeli May 27, 2026 08:22
@ricardozanini
Copy link
Copy Markdown
Member

@cheryl7114 can you check the license headers?

@fantonangeli
Copy link
Copy Markdown
Member

@cheryl7114 can you check the license headers?

@ricardozanini I think it's a cache issue, trying to save an empty node_modules directory in the cache.
With the next commit it should be green but I'm opening an issue now so I can fix it

Copilot AI review requested due to automatic review settings May 27, 2026 14:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copy link
Copy Markdown
Contributor

@handreyrc handreyrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cheryl7114,
LGTM, thanks for your work!

Copy link
Copy Markdown
Member

@fantonangeli fantonangeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small suggestion for the changeset

Comment thread .changeset/grumpy-buttons-cheat.md Outdated
Comment thread .changeset/grumpy-buttons-cheat.md
Copilot AI review requested due to automatic review settings May 27, 2026 14:41
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Cheryl Kong and others added 3 commits May 27, 2026 15:55
Signed-off-by: Cheryl Kong <cherylkong50@gmail.com>
Co-authored-by: Fabrizio Antonangeli <fabrizio.antonangeli@gmail.com>
Signed-off-by: Cheryl Kong <cherylkong50@gmail.com>
Signed-off-by: Cheryl Kong <cherylkong50@gmail.com>
Copilot AI review requested due to automatic review settings May 27, 2026 14:56
@cheryl7114 cheryl7114 force-pushed the storybook-styling-127 branch from 96668ae to e86b49f Compare May 27, 2026 14:56
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@cheryl7114 cheryl7114 requested a review from ricardozanini May 27, 2026 15:05
@cheryl7114
Copy link
Copy Markdown
Contributor Author

@ricardozanini this PR looks ready to be merged if you don't have any other suggestions ?

@ricardozanini ricardozanini merged commit 88f7131 into serverlessworkflow:main May 27, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Implement Storybook structure and styling

6 participants