fix #127 - feat: Implement Storybook structure and styling#151
Conversation
There was a problem hiding this comment.
Pull request overview
This PR streamlines the serverless-workflow-diagram-editor package’s Storybook setup by removing the default Storybook “Example” boilerplate components/docs and aligning the remaining stories under a Features/* hierarchy with corrected source import paths.
Changes:
- Removed Storybook starter boilerplate (Button/Header/Page components, CSS, and Configure docs MDX).
- Reorganized remaining stories under
Features/*titles for clearer navigation. - Fixed story imports to reference the package
src/from thestories/features/directory (e.g.,../../src/...).
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/serverless-workflow-diagram-editor/stories/Page.tsx | Removed Storybook starter “Page” boilerplate component. |
| packages/serverless-workflow-diagram-editor/stories/Page.stories.ts | Removed Storybook starter “Page” story (incl. interaction test). |
| packages/serverless-workflow-diagram-editor/stories/page.css | Removed CSS used only by the deleted starter “Page”. |
| packages/serverless-workflow-diagram-editor/stories/Header.tsx | Removed Storybook starter “Header” boilerplate component. |
| packages/serverless-workflow-diagram-editor/stories/Header.stories.ts | Removed Storybook starter “Header” story. |
| packages/serverless-workflow-diagram-editor/stories/header.css | Removed CSS used only by the deleted starter “Header”. |
| packages/serverless-workflow-diagram-editor/stories/Configure.mdx | Removed Storybook starter Configure docs page. |
| packages/serverless-workflow-diagram-editor/stories/Button.tsx | Removed Storybook starter “Button” boilerplate component. |
| packages/serverless-workflow-diagram-editor/stories/Button.stories.ts | Removed Storybook starter “Button” story. |
| packages/serverless-workflow-diagram-editor/stories/button.css | Removed CSS used only by the deleted starter “Button”. |
| packages/serverless-workflow-diagram-editor/stories/features/ErrorPage.stories.tsx | Updated imports to ../../src/... and renamed story title to Features/ErrorPage. |
| packages/serverless-workflow-diagram-editor/stories/features/DiagramEditorDragNDrop.tsx | Updated import path to ../../src/diagram-editor/DiagramEditor. |
| packages/serverless-workflow-diagram-editor/stories/features/DiagramEditorDragNDrop.stories.ts | Renamed story title to Features/Diagram-Editor-Drag-N-Drop. |
| packages/serverless-workflow-diagram-editor/stories/features/DiagramEditor.tsx | Updated import path to ../../src/diagram-editor/DiagramEditor. |
| packages/serverless-workflow-diagram-editor/stories/features/DiagramEditor.stories.ts | Renamed story title to Features/Diagram-Editor. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fantonangeli
left a comment
There was a problem hiding this comment.
LGTM, Just 2 small suggestions
Thanks @cheryl7114
Signed-off-by: Cheryl Kong <cherylkong50@gmail.com>
Signed-off-by: Cheryl Kong <cherylkong50@gmail.com>
Signed-off-by: Cheryl Kong <cherylkong50@gmail.com>
Signed-off-by: Cheryl Kong <cherylkong50@gmail.com>
Signed-off-by: Cheryl Kong <cherylkong50@gmail.com>
Signed-off-by: Cheryl Kong <cherylkong50@gmail.com>
36b47dd to
a7d09e8
Compare
✅ Deploy Preview for swf-editor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@ricardozanini our Netlify configuration is working 🚀 |
Signed-off-by: Cheryl Kong <cherylkong50@gmail.com>
Signed-off-by: Cheryl Kong <cherylkong50@gmail.com>
…e support Signed-off-by: Cheryl Kong <cherylkong50@gmail.com>
|
@cheryl7114 can you check the license headers? |
@ricardozanini I think it's a cache issue, trying to save an empty node_modules directory in the cache. |
handreyrc
left a comment
There was a problem hiding this comment.
@cheryl7114,
LGTM, thanks for your work!
fantonangeli
left a comment
There was a problem hiding this comment.
LGTM, just a small suggestion for the changeset
Signed-off-by: Cheryl Kong <cherylkong50@gmail.com>
Co-authored-by: Fabrizio Antonangeli <fabrizio.antonangeli@gmail.com> Signed-off-by: Cheryl Kong <cherylkong50@gmail.com>
Signed-off-by: Cheryl Kong <cherylkong50@gmail.com>
96668ae to
e86b49f
Compare
|
@ricardozanini this PR looks ready to be merged if you don't have any other suggestions ? |
Closes #127
Description
This PR implements the following changes to Storybook: