Skip to content

Improve CMS/Kerberos support of other hashes#4974

Merged
gpotter2 merged 1 commit intosecdev:masterfrom
gpotter2:cms-pkinit-fixes
Apr 20, 2026
Merged

Improve CMS/Kerberos support of other hashes#4974
gpotter2 merged 1 commit intosecdev:masterfrom
gpotter2:cms-pkinit-fixes

Conversation

@gpotter2
Copy link
Copy Markdown
Member

This PR:

  • merges the different "Hash" crypto implementations of TLS and IPSEC/RFC3961
  • fixes support for non-sha1 hashes in CMS
  • improve PKINIT support
  • fix p12= being broken in KerberosClient

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

❌ Patch coverage is 52.63158% with 90 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.27%. Comparing base (f6793df) to head (19c132f).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
scapy/layers/kerberos.py 9.37% 58 Missing ⚠️
scapy/layers/tls/cert.py 52.38% 20 Missing ⚠️
scapy/layers/tls/crypto/hash.py 85.71% 6 Missing ⚠️
scapy/layers/windows/registry.py 0.00% 5 Missing ⚠️
scapy/layers/tls/crypto/prf.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4974      +/-   ##
==========================================
- Coverage   80.31%   80.27%   -0.05%     
==========================================
  Files         381      381              
  Lines       93630    93716      +86     
==========================================
+ Hits        75201    75232      +31     
- Misses      18429    18484      +55     
Files with missing lines Coverage Δ
scapy/asn1/mib.py 91.87% <ø> (ø)
scapy/layers/gssapi.py 84.67% <100.00%> (ø)
scapy/layers/tls/crypto/h_mac.py 92.85% <100.00%> (+0.21%) ⬆️
scapy/layers/tls/crypto/hkdf.py 98.11% <100.00%> (ø)
scapy/layers/tls/crypto/pkcs1.py 76.27% <100.00%> (-0.48%) ⬇️
scapy/layers/tls/crypto/suites.py 100.00% <100.00%> (ø)
scapy/layers/windows/erref.py 100.00% <ø> (ø)
scapy/modules/ticketer.py 46.01% <ø> (ø)
scapy/layers/tls/crypto/prf.py 92.50% <92.85%> (ø)
scapy/layers/windows/registry.py 0.00% <0.00%> (ø)
... and 3 more

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gpotter2 gpotter2 force-pushed the cms-pkinit-fixes branch 2 times, most recently from 1f44041 to b17c616 Compare April 20, 2026 14:20
@gpotter2 gpotter2 merged commit 366530e into secdev:master Apr 20, 2026
23 of 24 checks passed
@gpotter2 gpotter2 deleted the cms-pkinit-fixes branch April 20, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant