LLDP: add IEEE 802.1Q and 802.1AX org-specific TLVs#4970
LLDP: add IEEE 802.1Q and 802.1AX org-specific TLVs#4970ali-keys wants to merge 1 commit intosecdev:masterfrom
Conversation
…rg-specific dispatch
|
Thanks for the PR. Could you please check if it is possible to add interoperability tests with existing tools or libraries, such as lldpd, to the unit tests. |
Hi Nils, by interoperability tests you mean: Making a real environment -> capturing everything -> writing tests based on the pcaps to make sure it gets parsed correctly? Like the last test ( |
|
No, those tests are also important, but if possible I have something like this in mind. Start lldpd with a certain configuration in a subprocess, In this way we can automatically verify the interaction with a real world application/libray. |
Hi everyone,
This PR adds 15 new org-specific TLVs for IEEE 802.1Q:
First, I wanted to implement only the ones that I needed (VLAN stuff), but then decided to implement all of them.
The code has been written mostly by AI. I've reviewed and corrected every line of it.