Skip to content

Fix #128#549

Closed
Kilip1000 wants to merge 1 commit intoryanhcode:mainfrom
Kilip1000:main
Closed

Fix #128#549
Kilip1000 wants to merge 1 commit intoryanhcode:mainfrom
Kilip1000:main

Conversation

@Kilip1000
Copy link
Copy Markdown

@Kilip1000 Kilip1000 commented Apr 26, 2026

Fixes #128.
This is done by taking the maximum of the light level applied in the method, and the original light level with no changes applied.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 26, 2026

CLA assistant check
All committers have signed the CLA.

@ryanhcode ryanhcode self-assigned this Apr 26, 2026
@ryanhcode
Copy link
Copy Markdown
Owner

we would then be doing double the light queries

@Kilip1000
Copy link
Copy Markdown
Author

Kilip1000 commented Apr 26, 2026

we would then be doing double the light queries

Do you mean to say that preserving the original light-level is not worth it, unless the execution of those light queries is at no additional cost? I, frankly, believe that's infeasible/impossible to do.

@ryanhcode
Copy link
Copy Markdown
Owner

No, there is a way to both preserve the original light level here and also to incorporate the sub-level light levels

@Kilip1000
Copy link
Copy Markdown
Author

No, there is a way to both preserve the original light level here and also to incorporate the sub-level light levels

How's that possible if the original value does not get evaluated/incorporated?

@ryanhcode
Copy link
Copy Markdown
Owner

also, calling Math.max on an already packed light value pair isn't a valid operation. I'm working on a fix that shouldn't add any more additional queries and should fix this

@Kilip1000
Copy link
Copy Markdown
Author

Ah, right, I forgot one of the light values is a higher power of two than the other and would thus unintentionally take priority!
I'm sorry for wasting your time 😓

@Kilip1000 Kilip1000 closed this Apr 26, 2026
@ryanhcode
Copy link
Copy Markdown
Owner

you're all good! thank you for bringing the issue to light

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dynamic Light issue

3 participants