Conversation
Fixes ryanhcode#128.
|
we would then be doing double the light queries |
Do you mean to say that preserving the original light-level is not worth it, unless the execution of those light queries is at no additional cost? I, frankly, believe that's infeasible/impossible to do. |
|
No, there is a way to both preserve the original light level here and also to incorporate the sub-level light levels |
How's that possible if the original value does not get evaluated/incorporated? |
|
also, calling Math.max on an already packed light value pair isn't a valid operation. I'm working on a fix that shouldn't add any more additional queries and should fix this |
|
Ah, right, I forgot one of the light values is a higher power of two than the other and would thus unintentionally take priority! |
|
you're all good! thank you for bringing the issue to light |
Fixes #128.
This is done by taking the maximum of the light level applied in the method, and the original light level with no changes applied.