Skip to content

fix(theme): fix null reference error by executing theme script after DOM loads #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Moamal-2000 wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −16
Open

fix(theme): fix null reference error by executing theme script after DOM loads #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions _includes/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,22 +19,6 @@ export default function Layout(
title="Ryan Dahl"
href="/feed"
/>
<script
dangerouslySetInnerHTML={{
__html: `
function toggleTheme() {
document.body.classList.toggle('dark');
localStorage.setItem('theme', document.body.classList.contains('dark') ? 'dark' : 'light');
}

// Apply saved theme on load
if (localStorage.getItem('theme') === 'dark' ||
(!localStorage.getItem('theme') && window.matchMedia('(prefers-color-scheme: dark)').matches)) {
document.body.classList.add('dark');
}
`,
}}
/>
<style
dangerouslySetInnerHTML={{
__html: `
Expand Down Expand Up @@ -299,6 +283,22 @@ export default function Layout(
<div class="container">
{children}
</div>
<script
dangerouslySetInnerHTML={{
__html: `
function toggleTheme() {
document.body.classList.toggle('dark');
localStorage.setItem('theme', document.body.classList.contains('dark') ? 'dark' : 'light');
}

// Apply saved theme on load
if (localStorage.getItem('theme') === 'dark' ||
(!localStorage.getItem('theme') && window.matchMedia('(prefers-color-scheme: dark)').matches)) {
document.body.classList.add('dark');
}
`,
}}
/>
</body>
</html>
);
Expand Down