Leverage static str key when possible#727
Merged
KodrAus merged 3 commits intoJun 1, 2026
Merged
Conversation
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
commented
Jun 1, 2026
KodrAus
requested changes
Jun 1, 2026
Contributor
KodrAus
left a comment
There was a problem hiding this comment.
As noted, we should call the method from_str_static, to match the convention of other methods in log
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Thomasdezeeuw
approved these changes
Jun 1, 2026
KodrAus
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
&'k strinKey<'k>withMaybeStaticStr<'k>to leverage&'static strwhen in most cases it is.Open for review, especially on:
MaybeStaticStrcauses significant indirection.Otherwise, for downstream append, even if the key is a static str, one may have to
key.to_stringto resolve some lifetime issue. See:Key::from_static_str)slog::Key::from(static_str))